Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge panic-abort and panic-log crates into mc-sgx-panic #48

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

nick-mobilecoin
Copy link
Collaborator

@nick-mobilecoin nick-mobilecoin commented Jan 30, 2023

This moves the previously named mc-sgx-panic crate to
mc-sgx-panic-sys.

Previously there was:

  • mc-sgx-panic some common panic logic used by mc-sgx-sync for determining panic situations for lock aquisition logic. This was named vanilla panic as it was good enough at the time, but it still felt odd.
  • mc-sgx-panic-abort was a panic handler that only called abort()
  • mc-sgx-panic-log was a panic handler that would log and end in a spinloop

There was a desire to update the mc-sgx-panic-log to also abort(), or similar, it seemed that merging these 2 crates and providing a log feature would be a better path. It also seemed like mc-sgx-panic would be the crate that most clients would want to use. The mc-sgx-panic-sys name was chosen for the common panic backend logic as -sys is often used to indicate a system specific crate that clients shouldn't usually depend directly on.

@github-actions github-actions bot added the github_actions Pull requests that update github actions label Jan 30, 2023
This moves the previously named `mc-sgx-panic` crate to
`mc-sgx-panic-sys`.
Base automatically changed from nick/more-sync-docs to main February 1, 2023 16:39
@nick-mobilecoin nick-mobilecoin merged commit 01bc69c into main Feb 1, 2023
@nick-mobilecoin nick-mobilecoin deleted the nick/panic-log-aborts branch February 1, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update github actions rust Pull requests that update rust code size/L Large PRs
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants