-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge panic-abort and panic-log crates into mc-sgx-panic
#48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 30, 2023
Merged
Merged
Merged
Merged
nick-mobilecoin
force-pushed
the
nick/panic-log-aborts
branch
from
January 30, 2023 17:53
cbb1047
to
8e08030
Compare
github-actions
bot
added
the
github_actions
Pull requests that update github actions
label
Jan 30, 2023
7 tasks
nick-mobilecoin
force-pushed
the
nick/more-sync-docs
branch
from
January 30, 2023 22:54
caa0451
to
15c6824
Compare
nick-mobilecoin
force-pushed
the
nick/panic-log-aborts
branch
from
January 30, 2023 22:54
8e08030
to
0b65a13
Compare
This moves the previously named `mc-sgx-panic` crate to `mc-sgx-panic-sys`.
nick-mobilecoin
force-pushed
the
nick/more-sync-docs
branch
from
January 30, 2023 22:57
15c6824
to
df4dab1
Compare
nick-mobilecoin
force-pushed
the
nick/panic-log-aborts
branch
from
January 30, 2023 22:57
0b65a13
to
cdc44ad
Compare
This was referenced Jan 30, 2023
samdealy
approved these changes
Feb 1, 2023
jcape
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
github_actions
Pull requests that update github actions
rust
Pull requests that update rust code
size/L
Large PRs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the previously named
mc-sgx-panic
crate tomc-sgx-panic-sys
.Previously there was:
mc-sgx-panic
some common panic logic used bymc-sgx-sync
for determining panic situations for lock aquisition logic. This was named vanillapanic
as it was good enough at the time, but it still felt odd.mc-sgx-panic-abort
was a panic handler that only calledabort()
mc-sgx-panic-log
was a panic handler that would log and end in a spinloopThere was a desire to update the
mc-sgx-panic-log
to alsoabort()
, or similar, it seemed that merging these 2 crates and providing alog
feature would be a better path. It also seemed likemc-sgx-panic
would be the crate that most clients would want to use. Themc-sgx-panic-sys
name was chosen for the common panic backend logic as-sys
is often used to indicate a system specific crate that clients shouldn't usually depend directly on.