Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the mc-sgx-tstdc crate #256

Merged
merged 4 commits into from
Jan 25, 2023
Merged

Add the mc-sgx-tstdc crate #256

merged 4 commits into from
Jan 25, 2023

Conversation

nick-mobilecoin
Copy link
Collaborator

Add Mutex primitive

@nick-mobilecoin nick-mobilecoin mentioned this pull request Jan 13, 2023
Merged
@nick-mobilecoin
Copy link
Collaborator Author

nick-mobilecoin commented Jan 13, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@github-actions github-actions bot requested review from NotGyro and samdealy January 13, 2023 18:14
@github-actions github-actions bot added rust Pull requests that update Rust code size/L PRs with more than 500 lines of changes labels Jan 13, 2023
nick-mobilecoin
nick-mobilecoin commented Jan 13, 2023
View reviewed changes
tstdc/src/mutex.rs Outdated Show resolved Hide resolved
nick-mobilecoin
nick-mobilecoin commented Jan 13, 2023
View reviewed changes
tstdc/src/mutex.rs Outdated Show resolved Hide resolved
@nick-mobilecoin nick-mobilecoin force-pushed the nick/tstdc branch 3 times, most recently from 54b309c to 12c88f9 Compare January 17, 2023 19:26
@nick-mobilecoin nick-mobilecoin mentioned this pull request Jan 17, 2023
Merged
samdealy
samdealy approved these changes Jan 23, 2023
View reviewed changes
tstdc/README.md Show resolved Hide resolved
tstdc/src/mutex.rs Outdated Show resolved Hide resolved
tstdc/src/mutex.rs Outdated Show resolved Hide resolved
tstdc/src/mutex.rs Outdated Show resolved Hide resolved
tstdc/src/mutex.rs Outdated Show resolved Hide resolved
This was referenced Jan 24, 2023
Merged
Merged
NotGyro
NotGyro approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@NotGyro NotGyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nick-mobilecoin nick-mobilecoin requested a review from jcape January 25, 2023 20:43
Base automatically changed from nick/const-tstdc-types to main January 25, 2023 20:45
@codecov-commenter
Copy link

Codecov Report

Merging #256 (001eb82) into main (6f8b055) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #256   +/-   ##
=======================================
  Coverage   90.27%   90.27%           
=======================================
  Files          45       45           
  Lines        3950     3950           
=======================================
  Hits         3566     3566           
  Misses        384      384

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nick-mobilecoin
Add the mc-sgx-tstdc crate
b6a482c
@nick-mobilecoin
Update documentation on Mutex
590d89b
@nick-mobilecoin
Change Mutex::try_lock() to return Result<bool>
204031f 
Previously `try_lock()` would return `Ok(())` or `Err(Error)`. This
resulted in `Error::Busy` coming back in `Err()` when another thread had
the lock. Another thread owning the lock in a `try_lock()` call is
expected behavior and isn't a traditional _error_. Now `try_lock()`
returns a `bool` in normal expected operation to indicate if the lock
was acquired or not.
@nick-mobilecoin
Fix new beta clippy warning
53886fa
@nick-mobilecoin
Copy link
Collaborator Author

nick-mobilecoin commented Jan 25, 2023 •
edited
Loading

✅ This pull request merged successfully as part of a Graphite job
Stack job ID: oVCQ2kHpI2qOxWNUHTpX.
See details on graphite.dev

@nick-mobilecoin nick-mobilecoin merged commit 957abb0 into main Jan 25, 2023
@nick-mobilecoin nick-mobilecoin deleted the nick/tstdc branch January 25, 2023 21:44
@nick-mobilecoin nick-mobilecoin mentioned this pull request Jan 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdealy samdealy samdealy approved these changes

@NotGyro NotGyro NotGyro approved these changes

@jcape jcape jcape approved these changes

Assignees

@nick-mobilecoin nick-mobilecoin

Labels
rust Pull requests that update Rust code size/L PRs with more than 500 lines of changes
Projects
Blockchain Core
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nick-mobilecoin @codecov-commenter @jcape @NotGyro @samdealy