Add RwLock to mc-sgx-tstdc
#260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 25, 2023
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #260 +/- ##
=======================================
Coverage 90.30% 90.30%
=======================================
Files 45 45
Lines 3949 3949
=======================================
Hits 3566 3566
Misses 383 383 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
nick-mobilecoin
force-pushed
the
nick/condvar
branch
from
11ca0e6 to
a9d62a9
Compare
jcape
approved these changes
Jan 25, 2023
nick-mobilecoin
force-pushed
the
nick/rwlock
branch
from
018f2da to
79a007e
Compare
Previously `try_lock()` would return `Ok(())` or `Err(Error)`. This resulted in `Error::Busy` coming back in `Err()` when another thread had the lock. Another thread owning the lock in a `try_lock()` call is expected behavior and isn't a traditional _error_. Now `try_lock()` returns a `bool` in normal expected operation to indicate if the lock was acquired or not.
nick-mobilecoin
force-pushed
the
nick/rwlock
branch
from
79a007e to
599094d
Compare
varsha888
approved these changes
Jan 27, 2023
|
✅ This pull request merged successfully as part of a Graphite job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.