Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize RustCrypto for SecP256R1 #27

Merged
merged 6 commits into from
Jul 27, 2022
Merged

Conversation

nick-mobilecoin
Copy link
Collaborator

Previously rust-mbedtls was utilized for the elliptical curve signature
verifications. Now RustCrypto is used for elliptical curve signatures.

This was referenced Jul 18, 2022
@nick-mobilecoin
Copy link
Collaborator Author

nick-mobilecoin commented Jul 18, 2022

@nick-mobilecoin nick-mobilecoin force-pushed the feature/verify_attestation_key branch from 4390d48 to d8d7e31 Compare July 18, 2022 22:43
@nick-mobilecoin nick-mobilecoin force-pushed the feature/use_rustcrypto branch from df49ef0 to 7214c63 Compare July 18, 2022 22:43
@nick-mobilecoin nick-mobilecoin force-pushed the feature/verify_attestation_key branch from d8d7e31 to 82eb7bc Compare July 18, 2022 23:00
@nick-mobilecoin nick-mobilecoin force-pushed the feature/use_rustcrypto branch from 7214c63 to bf92428 Compare July 18, 2022 23:00
Base automatically changed from feature/verify_attestation_key to develop July 18, 2022 23:02
@nick-mobilecoin nick-mobilecoin force-pushed the feature/use_rustcrypto branch from bf92428 to c7ed04e Compare July 18, 2022 23:03
@nick-mobilecoin nick-mobilecoin self-assigned this Jul 19, 2022
@nick-mobilecoin nick-mobilecoin requested a review from a team July 19, 2022 13:52
Copy link
Contributor

@awygle awygle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Previously rust-mbedtls was utilized for the elliptical curve signature
verifications.  Now RustCrypto is used for elliptical curve signatures.
@nick-mobilecoin nick-mobilecoin force-pushed the feature/use_rustcrypto branch from c7ed04e to 09955fb Compare July 26, 2022 20:02
nick-mobilecoin and others added 5 commits July 26, 2022 13:20
Previously nightly-2022-07-22 was used.  This caused compilation errors
with the asn1-rs crate.
The previous commit failed to add the lock file updates for utilizing
the new crates.
…ficate_chain

Verify the quote certificate chain
Copy link
Contributor

@jcape jcape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now, but we should look to replace it later with something akin to mc-attest-verify in the future.

untrusted/quote_verify/Cargo.toml Show resolved Hide resolved
@nick-mobilecoin nick-mobilecoin merged commit e59e434 into develop Jul 27, 2022
@nick-mobilecoin nick-mobilecoin deleted the feature/use_rustcrypto branch July 27, 2022 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants