-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utilize RustCrypto for SecP256R1 #27
Conversation
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
4390d48
to
d8d7e31
Compare
df49ef0
to
7214c63
Compare
d8d7e31
to
82eb7bc
Compare
7214c63
to
bf92428
Compare
bf92428
to
c7ed04e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Previously rust-mbedtls was utilized for the elliptical curve signature verifications. Now RustCrypto is used for elliptical curve signatures.
c7ed04e
to
09955fb
Compare
Previously nightly-2022-07-22 was used. This caused compilation errors with the asn1-rs crate.
The previous commit failed to add the lock file updates for utilizing the new crates.
…ficate_chain Verify the quote certificate chain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine for now, but we should look to replace it later with something akin to mc-attest-verify
in the future.
Previously rust-mbedtls was utilized for the elliptical curve signature
verifications. Now RustCrypto is used for elliptical curve signatures.