Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify the quote certificate chain #28

Merged
merged 3 commits into from
Jul 26, 2022

Conversation

nick-mobilecoin
Copy link
Collaborator

No description provided.

@nick-mobilecoin
Copy link
Collaborator Author

nick-mobilecoin commented Jul 19, 2022

Copy link
Contributor

@awygle awygle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! It might be worth citing some source for the certificate ordering, if we have one, or mentioning it's empirically determined, but I wouldn't block on that.

@nick-mobilecoin nick-mobilecoin force-pushed the feature/verify_certificate_chain branch from 3a29d6a to 4a56eb3 Compare July 26, 2022 20:29
@NotGyro
Copy link
Contributor

NotGyro commented Jul 26, 2022

Tests are failing in CI, but it looks like that's just because somebody needs to build this locally so that Cargo.lock gets updated, and then commit the updated Cargo.lock. The specific error message is error: the lock file /__w/sgx/sgx/untrusted/Cargo.lock needs to be updated but --locked was passed to prevent this

I could try this, but I don't know if I'd be stepping on anything important by committing to this branch right now.

@nick-mobilecoin
Copy link
Collaborator Author

nick-mobilecoin commented Jul 26, 2022

Tests are failing in CI

Should be good now, if I did it all correctly...

Copy link
Contributor

@NotGyro NotGyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I like the concise but informative comments.

@NotGyro NotGyro merged commit 7978d21 into feature/use_rustcrypto Jul 26, 2022
@NotGyro NotGyro deleted the feature/verify_certificate_chain branch July 26, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants