use object (key is type safe) to choice alert message rather than switch

[pankona]

How about to use object (hash map) to choice alert message?
I think this is same with using switch statement from the perspective of type safety.

[kachick]

Suggested change

	const alertMessageByNotificationPermission: {
	[key in NotificationPermission]: string;
	} = {
	granted: "Thanks to accept the notification :)",
	denied: "You rejected the notification :(Please accept it.",
	default: "Can not judge to use notification :(Please accept it.",
	};
	const alertMessageByNotificationPermission = {
	granted: "Thanks to accept the notification :)",
	denied: "You rejected the notification :(Please accept it.",
	default: "Can not judge to use notification :(Please accept it.",
	} as const;

is simple and robust here, dependent NotificationPermission is enough in fetching key, I think

And I suggest to put this object out of this Timer function, this does not depends any context and variables.

[pankona]

I got another idea now. How about this?

      if (window.Notification && Notification.permission !== "granted") {
        Notification.requestPermission((result) => {
          const alertMessageByNotificationPermission: {
            [key in typeof result]: string;
          } = {
            granted: "Thanks to accept the notification :)",
            denied: "You rejected the notification :(Please accept it.",
            default: "Can not judge to use notification :(Please accept it.",
          };
          alert(alertMessageByNotificationPermission[result]);
        });
      }

My thought of key in ~'s advantages are:

• Using as const doesn't prevent adding "extra" elements.
• key in ~ can get good IDE support.

On the other hand, I agree using as const is more simpler.
I'd like to hear your opinion again which is better.

[kachick]

I can understand your motivation to write key ~.

I have 2 suggestions as below

        Notification.requestPermission((result) => {
          alert(
            {
              granted: "Thanks to accept the notification :)",
              denied: "You rejected the notification :(Please accept it.",
              default: "Can not judge to use notification :(Please accept it.",
            }[result]
          );
        });

This is simple and typescript supports the branches, my favor.
The constant only use here, less cost, so writing as literal is best, I think.

However if you want to extract to another variable, as const makes readonly, I prefer the benefit.

Suggested change

	const alertMessageByNotificationPermission: {
	[key in NotificationPermission]: string;
	} = {
	granted: "Thanks to accept the notification :)",
	denied: "You rejected the notification :(Please accept it.",
	default: "Can not judge to use notification :(Please accept it.",
	};
	const alertMessageByNotificationPermission: Readonly<{
	[key in NotificationPermission]: string;
	}> = {
	granted: "Thanks to accept the notification :)",
	denied: "You rejected the notification :(Please accept it.",
	default: "Can not judge to use notification :(Please accept it.",
	};

This is a similar way as this.

[pankona]

I like it! Let me update.

[pankona]

addressed in 2e302af
Cloud you check again?

[kachick]

I would update this with #724

[kachick]

HashMap based state transition is one of my favor too. I agree to use this way here 👍

(BTW, in TypeScript layer, it has same meanings. However thinking in JavaScript, it might be different for making error possibilities 😇 )

[kachick]

LGTM 👍