publish ubuntu and alpine variants images#5944
Closed
crazy-max wants to merge 5 commits intomoby:masterfrom
Closed
publish ubuntu and alpine variants images#5944crazy-max wants to merge 5 commits intomoby:masterfrom
crazy-max wants to merge 5 commits intomoby:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR switches the default base image for Buildkit to Debian and differentiates between Debian and Alpine variants.
- Updated the workflow matrix to include a new "base" key with values for Debian (empty string) and Alpine.
- Adjusted environment variable configurations accordingly to use the new matrix keys.
Files not reviewed (3)
- Dockerfile: Language not supported
- docker-bake.hcl: Language not supported
- hack/images: Language not supported
Comments suppressed due to low confidence (2)
.github/workflows/buildkit.yml:191
- [nitpick] The matrix key 'base' may not clearly indicate that an empty string represents Debian. Consider using a more descriptive name such as 'imageBase' to clarify intent.
+ base:
.github/workflows/buildkit.yml:192
- [nitpick] It might be helpful to add a comment explaining that an empty string for 'base' indicates the default Debian image, improving maintainability.
+ - ''
3 tasks
5d94f62 to
80285f9
Compare
Member
Author
|
Ubuntu rootless doesn't build with uid 1000 as it already exists. Wonder if we should change it for both Alpine and Ubuntu to be consistent 🤔 Edit: Skipped user creation and use one already created from base image. |
3 tasks
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
06447f5 to
6717bd4
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needs #6107
Push both alpine (default) and ubuntu buildkit image variants. Also push extra tag with
nvidiabuild tag enabled for ubuntu variant. This will allow us to setup CDI within the container for NVIDIA devices that require glibc for client librairies.