hack: use bake to build buildkit images#6107
Conversation
crazy-max
force-pushed
the
bake-images
branch
2 times, most recently
from
8993f77 to
e76584a
Compare
| name: Build | ||
| uses: docker/bake-action@v6 | ||
| with: | ||
| source: ${{ github.server_url }}/${{ github.repository }}.git#${{ github.ref }} |
There was a problem hiding this comment.
Can't use Git context from our actions-toolkit: https://github.com/docker/actions-toolkit/blob/633bcf1936ffff0e05a4bbe2b23c71abf6f4111e/src/context.ts#L45-L60
Because currently it fetches by sha and not git ref so tags are not pulled: https://github.com/crazy-max/buildkit/actions/runs/16967780276/job/48096258733#step:7:440. That would therefore set a commit sha as BuildKit version: https://github.com/crazy-max/buildkit/actions/runs/16967780276/job/48096258733#step:7:1654
docker/actions-toolkit#677 would fix it but it's probably better to wait for #5974.
So in the meantime set Git context manually with full git ref as we currently do in our hack script:
Line 43 in ec7a152
crazy-max
force-pushed
the
bake-images
branch
2 times, most recently
from
2c7f587 to
a20221c
Compare
crazy-max
force-pushed
the
bake-images
branch
from
ec17dd5 to
89e4915
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
bake-images
branch
from
89e4915 to
1fa57ee
Compare
2 participants
continue carrying changes from #3204