integration: use local registry mirrors #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
|
@AkihiroSuda I guess my thinking in b3c3e7d that dial errors in rootless are because of heavier parallelization is not correct. Any ideas? |
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
test-local
branch
from
b3c3e7d
to
087e11e
Compare
|
Green now. The issue was wrong perms on the config file. |
This was referenced Sep 12, 2018
tiborvass
reviewed
Sep 17, 2018
| @@ -55,6 +55,9 @@ func (r *readerAt) ReadAt(b []byte, off int64) (int, error) { | |||
| var totalN int | |||
| for len(b) > 0 { | |||
| n, err := r.Reader.Read(b) | |||
| if err == io.EOF && n == len(b) { | |||
There was a problem hiding this comment.
@tonistiigi I don't understand this. What if n < len(b) ?
There was a problem hiding this comment.
Then EOF is a regular error. This is actually workaround for containerd issue where some functions do not handle EOF properly as https://golang.org/pkg/io/#ReaderAt defines.
tiborvass
reviewed
Sep 17, 2018
| } | ||
|
|
||
| if mirrorDir != "" { | ||
| if err := syscall.Flock(int(f.Fd()), syscall.LOCK_UN); err != nil { |
There was a problem hiding this comment.
why not put this in a defer?, what if newRegistry or copyImagesLocal fails ?
There was a problem hiding this comment.
This lock releases automatically when test exits.
AkihiroSuda
approved these changes
Sep 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a local mirror for integration tests instead of pulling images all the time.
In the future, we may want to pass in the list of images per package as some of them are dockerfile specific. Also it may be easier (especially for the cleanup) if we would switch to
TestMain.For sharing between packages one can set
export BUILDKIT_REGISTRY_MIRROR_DIR=$(mktemp -d), but then they need to clean up this dir themselves as well. We could also set it inhack/testscript later.