Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockerfile: enable frontend selection in integration tests #622

Merged
merged 3 commits into from
Sep 20, 2018

Conversation

tonistiigi
Copy link
Member

based on #618
replaces #552

Allow running dockerfile tests in builtin, client and gateway modes.

By default tests builtin and client for all workers. Follow up should push an external gateway to the local registry and test that as well.

Filtering can be done with regular --run flag. eg go test --run ///frontend=builtin -v ./frontend/dockerfile to run all tests with only builtin or go test --run /TestCmdShell/worker=oci/frontend=client -v ./frontend/dockerfile for a specific test,worker,frontend combination.

Also accepts environment variables: FRONTEND_BUILTIN_ONLY, FRONTEND_CLIENT_ONLY.

To test external gateway:

FRONTEND_GATEWAY_ONLY=docker.io/tonistiigi/dockerfile:master go test -v ./frontend/dockerfile

@ijc

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚓

Copy link
Collaborator

@ijc ijc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for picking this up!

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@tonistiigi
Copy link
Member Author

I've rebased after #618 merge

@tonistiigi tonistiigi merged commit 3940458 into moby:master Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants