term_windows: use golang.org/x/sys/windows #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parts of github.com/Azure/go-ansiterm/winterm that were used is now provided by golang.org/x/sys/windows, so switch to that package, as it's more actively maintained. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
commented
May 7, 2020
| } else { | ||
| stdOut = os.Stdout | ||
| } | ||
|
|
||
| if emulateStderr { | ||
| stdErr = windowsconsole.NewAnsiWriter(syscall.STD_ERROR_HANDLE) | ||
| stdErr = windowsconsole.NewAnsiWriter(windows.STD_ERROR_HANDLE) |
There was a problem hiding this comment.
Probably worth linking; golang/sys@ff24cb3, in case that's not the correct thing to do in this context
|
LGTM !! thankfully it's mostly the same. |
|
looks pretty good. Most are simple replacements, and any other code difference looks good as well. |
|
Looks like this broke users at docker/for-win#9770, because |
|
Unfortunately I am unable to reproduce the issue linked to confirm what caused this. |
tklauser
added a commit
to tklauser/term-1
that referenced
this pull request
Aug 8, 2022
The code was switched back to x/sys/windows by moby#9. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parts of github.com/Azure/go-ansiterm/winterm that were used
is now provided by golang.org/x/sys/windows, so switch to that
package, as it's more actively maintained.