Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Winterm issue on Windows 8.1 in kubectl exec #1

Closed
wants to merge 1 commit into from

Conversation

n4j
Copy link
Owner

@n4j n4j commented Jun 10, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR fixes an issue with kubectl on certain version of Windows (Windows 8.1 and Windows 2012) or when legacy Console mode is enabled on Windows.

The issue was introduce for kubectl (and docker cli) in the package github.com\moby\term when moby/term#9 was merged to it. This caused incompatibility with github.com\Azure\go-ansiterm's method winterm.GetStdFile which expected flags for stdin, stdout, stderr from syscall package but instread moby\term passed flags from golang.org/x/sys/windows

The issue was fixed in go-ansiterm via Azure/go-ansiterm#31 and Azure/go-ansiterm#32 and merged to moby\term via moby/term#9

This PR upgrades the version of moby\term used in kubectl to fix kubernetes#102404

Which issue(s) this PR fixes:

Fixes # kubernetes#102404

Special notes for your reviewer:

Does this PR introduce a user-facing change?

No

Fixed an issue with kubectl on certain older version of Windows or when legacy console mode is enabled on Windows 8 which causes kubectl exec to crash

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@n4j
Copy link
Owner Author

n4j commented Jun 10, 2021

@neolit123 This is my first PR for kubernetes, could you please take a look at this PR and let me know if it's okay to raise it against kubernetes\master?

I have followed the vendoring instructions mentioned here

@n4j n4j changed the title Fix Winterm issue on Windows 8.1 in kubectl exec Fix - Winterm issue on Windows 8.1 in kubectl exec Jun 10, 2021
@n4j n4j closed this Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Winterm issue on Windows 8.1 in kubectl exec
1 participant