Fix - Winterm issue on Windows 8.1 in kubectl exec #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR fixes an issue with
kubectl
on certain version of Windows (Windows 8.1 and Windows 2012) or when legacy Console mode is enabled on Windows.The issue was introduce for kubectl (and docker cli) in the package
github.com\moby\term
when moby/term#9 was merged to it. This caused incompatibility withgithub.com\Azure\go-ansiterm
's methodwinterm.GetStdFile
which expected flags forstdin
,stdout
,stderr
fromsyscall
package but instreadmoby\term
passed flags fromgolang.org/x/sys/windows
The issue was fixed in
go-ansiterm
via Azure/go-ansiterm#31 and Azure/go-ansiterm#32 and merged tomoby\term
via moby/term#9This PR upgrades the version of
moby\term
used inkubectl
to fix kubernetes#102404Which issue(s) this PR fixes:
Fixes # kubernetes#102404
Special notes for your reviewer:
Does this PR introduce a user-facing change?
No
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: