Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links for Code of Conduct in MAINTAINERS.md lead to CHANGELOG.md #3450

Closed
1 of 4 tasks
mollstam opened this issue Aug 7, 2018 · 0 comments
Closed
1 of 4 tasks

Links for Code of Conduct in MAINTAINERS.md lead to CHANGELOG.md #3450

mollstam opened this issue Aug 7, 2018 · 0 comments

Comments

@mollstam
Copy link
Contributor

mollstam commented Aug 7, 2018

Prerequisites

  • Checked that your issue hasn't already been filed by cross-referencing issues with the faq label
  • Checked next-gen ES issues and syntax problems by using the same environment and/or transpiler configuration without Mocha to ensure it isn't just a feature that actually isn't supported in the environment in question or a bug in your code.
  • 'Smoke tested' the code to be tested by running it outside the real test suite to get a better sense of whether the problem is in the code under test, your usage of Mocha, or Mocha itself
  • Ensured that there is no discrepancy between the locally and globally installed versions of Mocha. You can find them with: node node_modules/.bin/mocha --version(Local) and mocha --version(Global). We recommend avoiding the use of globally installed Mocha.

Description

Reading Mocha Maintainer's Handbook the links to the code of conduct point to Mocha's changelog and not the actual code of conduct.

Steps to Reproduce

  1. Head to https://github.com/mochajs/mocha/blob/master/MAINTAINERS.md
  2. click any of the 2 links to the code of conduct

Expected behavior: Show code of conduct (https://github.com/mochajs/mocha/blob/master/.github/CODE_OF_CONDUCT.md)

Actual behavior: Changelog (https://github.com/mochajs/mocha/blob/master/CHANGELOG.md) is shown

Reproduces how often: 100%

Versions

MAINTAINERS.md on master since commit f060a74e 2017-10-16

Additional Information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants