Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves #3450: fixed links to "code of conduct" from MAINTAINERS.md #3451

Merged
merged 1 commit into from
Aug 7, 2018

Conversation

mollstam
Copy link
Contributor

@mollstam mollstam commented Aug 7, 2018

Description of the Change

I've changed the links to the code of conduct to lead where I expect them (the code of conduct) and not to the changelog.

Alternate Designs

There is a larger fix to MAINTAINERS.md by plroebuck@1d8afbf which utilizes much more fancy reference-style links which would probably be nice but I wanted to make as small a change as needed to fix the issue at hand

Why should this be in core?

Helping people find the code of conduct improves life for all. 💕

Benefits

Links in documentation lead where you expect them.

Possible Drawbacks

The element of discovery and exploration amidst hyperlinks between documentation is lost.

Applicable issues

#3450

@jsf-clabot
Copy link

jsf-clabot commented Aug 7, 2018

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 90.289% when pulling 5886af7 on mollstam:doc-maintainers-coc-links into f745651 on mochajs:master.

@outsideris outsideris added the area: documentation anything involving docs or mochajs.org label Aug 7, 2018
@outsideris outsideris merged commit 2bb4124 into mochajs:master Aug 7, 2018
@mollstam mollstam deleted the doc-maintainers-coc-links branch August 7, 2018 19:33
@boneskull boneskull added this to the v6.0.0 milestone Nov 5, 2018
sgilroy pushed a commit to TwineHealth/mocha that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation anything involving docs or mochajs.org
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants