Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠 Repo: Replace nps with ordinary npm scripts #5126

Closed
5 tasks done
voxpelli opened this issue Mar 26, 2024 · 0 comments · Fixed by #5128 or #5189
Closed
5 tasks done

🛠 Repo: Replace nps with ordinary npm scripts #5126

voxpelli opened this issue Mar 26, 2024 · 0 comments · Fixed by #5128 or #5189
Assignees
@voxpelli
Labels
area: repository tooling concerning ease of contribution status: accepting prs Mocha can use your help with this one!

Comments

@voxpelli
Copy link
Member

Tooling Suggestion Checklist

Overview

Similar to #5124, also comes from #5042 (comment), the use of nps makes the script running in this repository much more exotic and as such makes threshold higher for tools like knip as well as to human contributors who are not used to nps.

With 52 180 weekly downloads nps is not an established practice within the community. To make contributions easier we should replace it with ordinary npm scripts instead.

Additional Info

No response
@voxpelli voxpelli added status: accepting prs Mocha can use your help with this one! area: repository tooling concerning ease of contribution labels Mar 26, 2024
@voxpelli voxpelli self-assigned this Mar 26, 2024
@voxpelli voxpelli mentioned this issue Mar 26, 2024
Merged
voxpelli added a commit that referenced this issue Mar 26, 2024
@voxpelli
chore: WIP - replace nps with npm scripts
e5ea816 
Fixes #5126
@voxpelli voxpelli mentioned this issue Mar 26, 2024
Merged
7 tasks
@voxpelli voxpelli mentioned this issue Jun 4, 2024
Closed
voxpelli added a commit that referenced this issue Jul 15, 2024
@voxpelli
ci: generate the coverage report using nps for now
19ae145 
See #5126
voxpelli added a commit that referenced this issue Jul 15, 2024
@voxpelli
ci: generate the coverage report using nps for now
e769953 
See #5126
@voxpelli voxpelli moved this to In Progress in Maintenance Reboot Aug 1, 2024
voxpelli added a commit that referenced this issue Aug 1, 2024
@voxpelli
ci: github actions workflow improvements (#5177)
a8f8c8b 
* ci: use `npm ci` consistently

* ci: use `actions/setup-node` cache mechanism

* ci: reusable workflow for DRY:er setup

* ci: remove unused `delete-runs.yml`

* ci: fix matrix definitions

* ci: fix matrix definitions, take 2

* ci: ensure they all scripts can use `npm run`

See also #5128

* ci: add node 22 to `test-node`

* ci: have the coverage run always happen on `lts/*`

* ci: set permissions

* ci: lock down all non-github actions by hash

* ci: use reusable workflow for full tests as well

* ci: remove redundant activity types

* ci: add one more permissions

* ci: use full sha hashes for third party workflows

* ci: be consistent in naming

* ci: generate the coverage report using nps for now

See #5126

* ci: parallelize, run local browser test right away

* ci: disable saucelabs for now, too noisy
@github-project-automation github-project-automation bot moved this from In Progress to Done in Maintenance Reboot Aug 5, 2024
@github-actions github-actions bot mentioned this issue Aug 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@voxpelli voxpelli

Labels
area: repository tooling concerning ease of contribution status: accepting prs Mocha can use your help with this one!
Projects
Maintenance Reboot
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: replace nps with npm scripts mochajs/mocha
chore(main): release 10.7.1 mochajs/mocha
1 participant
@voxpelli