-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add knip to validate included dependencies #5042
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thoughts:
That leaves this PR doing only |
Still eg. complains on:
|
17 tasks
3 tasks
JoshuaKGoldberg
added
the
status: waiting for author
waiting on response from OP - more information needed
label
Mar 4, 2024
This was referenced Mar 26, 2024
voxpelli
force-pushed
the
voxpelli/issue5041
branch
from
August 5, 2024 13:12
93a535f
to
150c5c9
Compare
voxpelli
changed the title
Look into adding Knip
chore: add knip to validate included dependencies
Aug 5, 2024
voxpelli
added
status: needs review
a maintainer should (re-)review this pull request
and removed
status: waiting for author
waiting on response from OP - more information needed
labels
Aug 5, 2024
This is ready now as well, after the merge of #5128 |
This was referenced Aug 5, 2024
JoshuaKGoldberg
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 let's ship it!
JoshuaKGoldberg
removed
the
status: needs review
a maintainer should (re-)review this pull request
label
Aug 6, 2024
voxpelli
added a commit
to voxpelli/knip
that referenced
this pull request
Aug 22, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Alternate Designs
Why should this be in core?
Benefits
Possible Drawbacks
Applicable issues