Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for discriminant_value #1021

Merged
merged 2 commits into from
Apr 7, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions tests/kani/Intrinsics/discriminant_value.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
// SPDX-License-Identifier: Apache-2.0 OR MIT

// Check that `discriminant_value` returns the expected results
// for different cases
#![feature(core_intrinsics)]
use std::intrinsics::discriminant_value;

// A standard enum with variants containing fields
enum MyError {
Error1(i32),
Error2(&'static str),
Error3 { description: String, code: u32 },
}

// An enum that assigns constant values to some variants
enum Constants {
A = 2,
B = 5,
C,
}

// An enum that assigns constant values (one of them negative) to all variants
enum Ordering {
Less = -1,
Equal = 0,
Greater = 1,
}

#[kani::proof]
fn main() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please split this into 3 different harnesses? I think it will make this much easier to read.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion, I didn't think about that! It's now split into 4 harnesses, can you take another look?

// Check that the values go from 0 to `num_variants - 1`
assert!(discriminant_value(&MyError::Error1) == 0);
assert!(discriminant_value(&MyError::Error2("bar")) == 1);
assert!(
discriminant_value(&MyError::Error3 { description: "some_error".to_string(), code: 3 })
== 2
);
// Check that the values are equal to the constants assigned
assert!(discriminant_value(&Ordering::Less) == -1);
assert!(discriminant_value(&Ordering::Equal) == 0);
assert!(discriminant_value(&Ordering::Greater) == 1);
// Check that the values are equal to the constants assigned
// and the non-assigned value follows from the assigned ones
assert!(discriminant_value(&Constants::A) == 2);
assert!(discriminant_value(&Constants::B) == 5);
assert!(discriminant_value(&Constants::C) == 6);
// Check that the value is 0 if the type has no discriminant
assert!(discriminant_value(&2) == 0);
}