-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a test for discriminant_value
#1021
Merged
adpaco-aws
merged 2 commits into
model-checking:main
from
adpaco-aws:discriminant_value-audit
Apr 7, 2022
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
// SPDX-License-Identifier: Apache-2.0 OR MIT | ||
|
||
// Check that `discriminant_value` returns the expected results | ||
// for different cases | ||
#![feature(core_intrinsics)] | ||
use std::intrinsics::discriminant_value; | ||
|
||
// A standard enum with variants containing fields | ||
enum MyError { | ||
Error1(i32), | ||
Error2(&'static str), | ||
Error3 { description: String, code: u32 }, | ||
} | ||
|
||
// An enum that assigns constant values to some variants | ||
enum Constants { | ||
A = 2, | ||
B = 5, | ||
C, | ||
} | ||
|
||
// An enum that assigns constant values (one of them negative) to all variants | ||
enum Ordering { | ||
Less = -1, | ||
Equal = 0, | ||
Greater = 1, | ||
} | ||
|
||
#[kani::proof] | ||
fn main() { | ||
// Check that the values go from 0 to `num_variants - 1` | ||
assert!(discriminant_value(&MyError::Error1) == 0); | ||
assert!(discriminant_value(&MyError::Error2("bar")) == 1); | ||
assert!( | ||
discriminant_value(&MyError::Error3 { description: "some_error".to_string(), code: 3 }) | ||
== 2 | ||
); | ||
// Check that the values are equal to the constants assigned | ||
assert!(discriminant_value(&Ordering::Less) == -1); | ||
assert!(discriminant_value(&Ordering::Equal) == 0); | ||
assert!(discriminant_value(&Ordering::Greater) == 1); | ||
// Check that the values are equal to the constants assigned | ||
// and the non-assigned value follows from the assigned ones | ||
assert!(discriminant_value(&Constants::A) == 2); | ||
assert!(discriminant_value(&Constants::B) == 5); | ||
assert!(discriminant_value(&Constants::C) == 6); | ||
// Check that the value is 0 if the type has no discriminant | ||
assert!(discriminant_value(&2) == 0); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please split this into 3 different harnesses? I think it will make this much easier to read.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion, I didn't think about that! It's now split into 4 harnesses, can you take another look?