Conform with recent rustc changes (caller_location intrinsic) #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avanhatt
reviewed
Aug 2, 2021
| @@ -304,6 +304,9 @@ impl<'tcx> GotocCtx<'tcx> { | |||
| "atomic_xsub_relaxed" => codegen_atomic_binop!(sub), | |||
| "breakpoint" => Stmt::skip(loc), | |||
| "bswap" => self.codegen_expr_to_place(p, fargs.remove(0).bswap()), | |||
| // TODO: Handle new `caller_location` intrinsic | |||
| // https://github.com/model-checking/rmc/issues/374 | |||
| "caller_location" => Stmt::skip(loc), | |||
There was a problem hiding this comment.
Nit: should this be codegen_unimplemented_intrinsic since it isn't used in any tests?
There was a problem hiding this comment.
Good idea, thanks! Updated both the code and #375.
avanhatt
approved these changes
Aug 2, 2021
vecchiot-aws
approved these changes
Aug 2, 2021
adpaco-aws
added a commit
that referenced
this pull request
Aug 6, 2021
* Handle `caller_location` intrinsic with skip statement * Use `codegen_unimplemented_instrinsic` instead
adpaco-aws
added a commit
that referenced
this pull request
Aug 17, 2021
* Handle `caller_location` intrinsic with skip statement * Use `codegen_unimplemented_instrinsic` instead
adpaco-aws
added a commit
that referenced
this pull request
Aug 24, 2021
* Handle `caller_location` intrinsic with skip statement * Use `codegen_unimplemented_instrinsic` instead
4 tasks
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 22, 2022
…checking#376) * Handle `caller_location` intrinsic with skip statement * Use `codegen_unimplemented_instrinsic` instead
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 25, 2022
…checking#376) * Handle `caller_location` intrinsic with skip statement * Use `codegen_unimplemented_instrinsic` instead
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
…checking#376) * Handle `caller_location` intrinsic with skip statement * Use `codegen_unimplemented_instrinsic` instead
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
* Handle `caller_location` intrinsic with skip statement * Use `codegen_unimplemented_instrinsic` instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This is PR handles the new
caller_locationintrinsic for #346 to be completed. Surprisingly, the regression has not failed in CI, but it is doing so locally. This has caused two new issues to be opened, #374 (extend intrinsic) and #375 (verify CI).Testing:
How is this change tested? Existing regression.
Is this a refactor change? No.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.