Remove panic::Location::<'a>::caller from skippable functions
#623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhassan-aws
approved these changes
Nov 4, 2021
danielsn
approved these changes
Nov 4, 2021
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 22, 2022
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 25, 2022
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Remove
panic::Location::<'a>::callerfrom the list of functions to skip.In #376 it was implemented as
codegen_unimplemented_intrinsic. #374 is open for handling it.Resolved issues:
Resolves #205
Call-outs:
Waiting for
std-lib-regression.shto be fixed in #593 so CI shows no issues with std-lib codegen.Testing:
How is this change tested? Running
std-lib-regression.shwith changes similar to Fix std lib regression script (#109 and #375) #593Is this a refactor change? No
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.