Set log level request and deserialization #118
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank your @maschnetwork for catching this issue! While reviewing the current logging support impl, I found other bugs addressed in #132 (which should cover this PR too - please review). Important note: The current broadcasting approach will be deprecated/removed. Logging should follow the same flow as sampling and roots, using the exchange to notify only clients in the session. |
|
Hi @tzolov, thank you. I see it being addressed in your PR. Let me know if you need any further help on this. |
|
Replaced by #132 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Addresses issue #97
How Has This Been Tested?
Tested with StdioTransport. Verfied that only configured logs are send after setLogLevel with local client. Since current TestSuite did not catch the initial issue a question remains on how to test the schema conformance in general. Open to ideas.
Breaking Changes
No
Types of changes
Checklist