feat(mcp): refactor logging to use exchange for targeted client notifications #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
chemicL
requested changes
Apr 9, 2025
...ing/mcp-spring-webflux/src/test/java/io/modelcontextprotocol/WebFluxSseIntegrationTests.java
Outdated
Show resolved
Hide resolved
...ing/mcp-spring-webflux/src/test/java/io/modelcontextprotocol/WebFluxSseIntegrationTests.java
Outdated
Show resolved
Hide resolved
...ing/mcp-spring-webflux/src/test/java/io/modelcontextprotocol/WebFluxSseIntegrationTests.java
Show resolved
Hide resolved
...ing/mcp-spring-webflux/src/test/java/io/modelcontextprotocol/WebFluxSseIntegrationTests.java
Outdated
Show resolved
Hide resolved
mcp-test/src/main/java/io/modelcontextprotocol/client/AbstractMcpAsyncClientTests.java
Outdated
Show resolved
Hide resolved
mcp/src/main/java/io/modelcontextprotocol/server/McpAsyncServerExchange.java
Outdated
Show resolved
Hide resolved
mcp/src/main/java/io/modelcontextprotocol/server/McpAsyncServerExchange.java
Outdated
Show resolved
Hide resolved
mcp/src/main/java/io/modelcontextprotocol/spec/McpServerSession.java
Outdated
Show resolved
Hide resolved
mcp/src/main/java/io/modelcontextprotocol/spec/McpServerSession.java
Outdated
Show resolved
Hide resolved
| @@ -44,7 +45,7 @@ | |||
|
|
|||
| public class HttpServletSseServerTransportProviderIntegrationTests { | |||
|
|
|||
| private static final int PORT = 8185; | |||
| private static final int PORT = 8189; | |||
There was a problem hiding this comment.
Why change? Perhaps we need a simple utility to allocate a random port instead of relying on a constant? https://stackoverflow.com/questions/2675362/how-to-find-an-available-port
There was a problem hiding this comment.
This makes sense. Spring Boot used to have such utility but discarded it for some reason.
Lets handle this in a dedicated issue/pr
…ications Refactors the MCP logging system to use the exchange mechanism for sending logging notifications only to specific client sessions rather than broadcasting to all clients. - Move logging notification delivery from server-wide broadcast to per-session exchange - Implement per-session minimum logging level tracking and filtering - Change setLoggingLevel from notification to request/response pattern - Deprecate global server.loggingNotification in favor of exchange.loggingNotification - Add integration test demonstrating filtered logging notifications Resolves #131 Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
- Implement AutoCloseable interface for McpAsyncClient, McpAsyncServer, and McpSyncServer - Refactor test methods to use try-with-resources for automatic resource cleanup - Add missing Javadoc for McpSyncServerExchange.setMinLoggingLevel - Change visibility of McpAsyncServerExchange.setMinLoggingLevel to package-private Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
…syncServerExchange Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
chemicL
reviewed
Apr 10, 2025
mcp/src/main/java/io/modelcontextprotocol/spec/McpServerSession.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Dariusz Jędrzejczyk <dariusz.jedrzejczyk@broadcom.com>
Signed-off-by: Dariusz Jędrzejczyk <dariusz.jedrzejczyk@broadcom.com>
tzolov
added a commit
that referenced
this pull request
Apr 10, 2025
…ications (#132) Refactors the MCP logging system to use the exchange mechanism for sending logging notifications only to specific client sessions rather than broadcasting to all clients. - Move logging notification delivery from server-wide broadcast to per-session exchange - Implement per-session minimum logging level tracking and filtering - Add proper logging level filtering at the exchange level - Change setLoggingLevel from notification to request/response pattern (breaking change) - Deprecate global server.loggingNotification in favor of exchange.loggingNotification - Add SetLevelRequest record to McpSchema - Add integration test demonstrating filtered logging notifications Resolves #131 Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com> Co-authored-by: Dariusz Jędrzejczyk <dariusz.jedrzejczyk@broadcom.com>
|
rebased, squashed and merged at c88ac93 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the MCP logging system to use the exchange mechanism for sending logging notifications only to specific client sessions rather than broadcasting to all clients.
Resolves #131