Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification on Installation step #66

Closed
jdillard opened this issue Mar 15, 2022 · 1 comment
Closed

Clarification on Installation step #66

jdillard opened this issue Mar 15, 2022 · 1 comment

Comments

@jdillard
Copy link
Collaborator

jdillard commented Mar 15, 2022

For step 3 in the Installation section "Add the binary to $PATH", can that be "Add the binary to $PATH or configure drawio_binary_path"? If so, I can make a PR to add that for clarity.

@modelmat
Copy link
Owner

if builder.config.drawio_binary_path:
binary_path = builder.config.drawio_binary_path
elif platform.system() == "Windows":
binary_path = r"C:\Program Files\draw.io\draw.io.exe"
else:
binary_path = "/opt/drawio/drawio"
if not os.path.isfile(binary_path):
binary_path = "/opt/draw.io/drawio"

I don't actually think $PATH was ever really used past perhaps the very early code.

I'll fix this, so don't worry about it.

modelmat added a commit that referenced this issue Jun 5, 2022
Fixes #23, #24 and #66.

Prioritises config-option binary_path, then programs in $PATH,
then the hardcoded absolute paths. Also raises an error if
cannot find the executable as opposed to just attempting to run
draw.io as a Linux program anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants