Improve drawio binary finding functionality to use $PATH #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modelmat
force-pushed
the
binary-path-improvements
branch
from
f8e82e7 to
c77be66
Compare
|
@benjamin-antupit @fcossio Could you test to confirm this works on mac? |
|
Looks all set to me (for MacOS at least). Thanks @modelmat! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23, #24 and #66.
Prioritises config-option binary_path, then programs in $PATH,
then the hardcoded absolute paths. Also raises an error if
cannot find the executable as opposed to just attempting to run
draw.io as a Linux program anyway.