Promote Canary releases to master

[Westbrook]

What we did

1. Rollup@v3
2. Updated rollup plugin versions
3. Updated LRU Cache
4. Use LRU Cache to the code coverage workflow
5. Removes testing for Node@14 (ends maintenance period next month) This is technically a break, did we catch all the version changes in the changeset @43081j?
6. Adds testing for Node@19
7. Mocha@v10

[changeset-bot]

🦋 Changeset detected

Latest commit: e707f6a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages

Name	Type
@web/test-runner-coverage-v8	Minor
@web/dev-server-core	Minor
@web/browser-logs	Minor
@web/config-loader	Minor
@web/dev-server	Minor
@web/dev-server-esbuild	Minor
@web/dev-server-hmr	Minor
@web/dev-server-import-maps	Minor
@web/dev-server-legacy	Major
@web/dev-server-rollup	Minor
@web/dev-server-storybook	Minor
@web/parse5-utils	Major
@web/polyfills-loader	Major
@web/rollup-plugin-copy	Minor
@web/rollup-plugin-html	Major
@web/rollup-plugin-import-meta-assets	Major
@web/rollup-plugin-polyfills-loader	Major
rollup-plugin-workbox	Major
@web/test-runner	Minor
@web/test-runner-browserstack	Minor
@web/test-runner-chrome	Minor
@web/test-runner-cli	Minor
@web/test-runner-commands	Minor
@web/test-runner-core	Minor
@web/test-runner-junit-reporter	Minor
@web/test-runner-mocha	Minor
@web/test-runner-playwright	Minor
@web/test-runner-puppeteer	Minor
@web/test-runner-saucelabs	Minor
@web/test-runner-selenium	Minor
@web/test-runner-visual-regression	Minor
@web/test-runner-webdriver	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[43081j]

I think we only have a changeset for the individual lru pr. We need to add one (or many) for the node support change.

I'm away on vacation at the min though so won't be able to add those until next week at least. If you know what to do, feel free

[Westbrook]

@43081j enjoy your holiday! When you're back, I wonder if you've seen this: #2132 in your testing. We're starting to see some good perf updates with these changes, but whatever underlying situation exists there might require us to continue to force prevent caching. 😢

[koddsson]

Are we ready to land this? I would have liked to get the mocha stuff in but I can't seem to figure it out.

[43081j]

what problem are you having exactly? with mocha

happy to take a look if you can point me the right direction to a failed build somewhere

[Westbrook]

I was hoping we could sneak in the Mocha update, but am pretty OK with moving forward. Maybe let @43081j have a run at it and were that not immediately productive we do the thing?

[koddsson]

what problem are you having exactly? with mocha

happy to take a look if you can point me the right direction to a failed build somewhere

Sure! Here's the PR: #2177

I don't fully understand the problem myself since I haven't actually been able to pinpoint what the issue is.

[koddsson]

[koddsson]

🦋  @web/browser-logs@0.0.0-canary-20230416222938
🦋  @web/config-loader@0.0.0-canary-20230416222938
🦋  @web/dev-server@0.0.0-canary-20230416222938
🦋  @web/dev-server-core@0.0.0-canary-20230416222938
🦋  @web/dev-server-esbuild@0.0.0-canary-20230416222938
🦋  @web/dev-server-hmr@0.0.0-canary-20230416222938
🦋  @web/dev-server-import-maps@0.0.0-canary-20230416222938
🦋  @web/dev-server-legacy@0.0.0-canary-20230416222938
🦋  @web/dev-server-rollup@0.0.0-canary-20230416222938
🦋  @web/dev-server-storybook@0.0.0-canary-20230416222938
🦋  @web/parse5-utils@0.0.0-canary-20230416222938
🦋  @web/polyfills-loader@0.0.0-canary-20230416222938
🦋  @web/rollup-plugin-copy@0.0.0-canary-20230416222938
🦋  @web/rollup-plugin-html@0.0.0-canary-20230416222938
🦋  @web/rollup-plugin-import-meta-assets@0.0.0-canary-20230416222938
🦋  @web/rollup-plugin-polyfills-loader@0.0.0-canary-20230416222938
🦋  rollup-plugin-workbox@0.0.0-canary-20230416222938
🦋  @web/test-runner@0.0.0-canary-20230416222938
🦋  @web/test-runner-browserstack@0.0.0-canary-20230416222938
🦋  @web/test-runner-chrome@0.0.0-canary-20230416222938
🦋  @web/test-runner-cli@0.0.0-canary-20230416222938
🦋  @web/test-runner-commands@0.0.0-canary-20230416222938
🦋  @web/test-runner-core@0.0.0-canary-20230416222938
🦋  @web/test-runner-coverage-v8@0.0.0-canary-20230416222938
🦋  @web/test-runner-junit-reporter@0.0.0-canary-20230416222938
🦋  @web/test-runner-mocha@0.0.0-canary-20230416222938
🦋  @web/test-runner-playwright@0.0.0-canary-20230416222938
🦋  @web/test-runner-puppeteer@0.0.0-canary-20230416222938
🦋  @web/test-runner-saucelabs@0.0.0-canary-20230416222938
🦋  @web/test-runner-selenium@0.0.0-canary-20230416222938
🦋  @web/test-runner-visual-regression@0.0.0-canary-20230416222938
🦋  @web/test-runner-webdriver@0.0.0-canary-20230416222938

[koddsson]

I've tested these locally and it looks great to me.

[Westbrook]

@43081j give a holler if this is looking good for you as well.

[43081j]

looks good to me, have also tried it again on our larger codebase and all seems fine

[koddsson]

Do we merge this now? That won't create a release, right? We then need to merge the changeset PR that gets created.