Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate node 14 #2195

Merged
merged 5 commits into from
Apr 4, 2023
Merged

Deprecate node 14 #2195

merged 5 commits into from
Apr 4, 2023

Conversation

koddsson
Copy link
Contributor

@koddsson koddsson commented Mar 31, 2023

Node 14 is reaching End Of Life soon.

References

https://nodejs.dev/en/about/releases/
Closes #2162

@changeset-bot
Copy link

changeset-bot bot commented Mar 31, 2023

🦋 Changeset detected

Latest commit: 895ad5c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@web/browser-logs Minor
@web/config-loader Minor
@web/dev-server Minor
@web/dev-server-core Minor
@web/dev-server-esbuild Minor
@web/dev-server-hmr Minor
@web/dev-server-import-maps Minor
@web/dev-server-legacy Major
@web/dev-server-rollup Minor
@web/dev-server-storybook Minor
@web/parse5-utils Major
@web/polyfills-loader Major
@web/rollup-plugin-copy Minor
@web/rollup-plugin-html Major
@web/rollup-plugin-import-meta-assets Major
@web/rollup-plugin-polyfills-loader Major
rollup-plugin-workbox Minor
@web/test-runner Minor
@web/test-runner-browserstack Minor
@web/test-runner-chrome Minor
@web/test-runner-cli Minor
@web/test-runner-commands Minor
@web/test-runner-core Minor
@web/test-runner-coverage-v8 Minor
@web/test-runner-junit-reporter Minor
@web/test-runner-mocha Minor
@web/test-runner-playwright Minor
@web/test-runner-puppeteer Minor
@web/test-runner-saucelabs Minor
@web/test-runner-selenium Minor
@web/test-runner-visual-regression Minor
@web/test-runner-webdriver Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@koddsson koddsson marked this pull request as ready for review March 31, 2023 16:51
@koddsson
Copy link
Contributor Author

Maybe this should actually be a minor bump.

@thepassle
Copy link
Member

I think changing the version in engines is technically a breaking change

@Westbrook
Copy link
Member

Some of these versions will be minor and some with be major. We’re looking at making these breaking version changes in #2180. Pointing this PR to next would be a great way to compare notes on the process.

@koddsson
Copy link
Contributor Author

Some of these versions will be minor and some with be major. We’re looking at making these breaking version changes in #2180. Pointing this PR to next would be a great way to compare notes on the process.

Ah! I thought there was another PR doing similar things, but I couldn't find it!

@koddsson koddsson changed the base branch from master to next March 31, 2023 19:25
@koddsson koddsson force-pushed the deprecate-node-14 branch 3 times, most recently from 703573f to 3e9ab02 Compare March 31, 2023 19:34
Copy link
Member

@Westbrook Westbrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These versions look good to me, barring rollup-plugin-workbox. This was one of the last pieces of the puzzle @43081j.

If we could get one more rebase @koddsson, I think we're good to go. We'll give a day for anyone to speak up on rollup-plugin-workbox and then be just about ready for a real release!

'@web/test-runner-webdriver': minor
---

Set node 16 as the minimum version.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rollup-plugin-workbox isn't included here. It doesn't have tests, so it might not actually be "effected" by this change, even though it is. Anyone have thoughts on this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm probably missing something, but why should it be included in this list?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason to include it would be that the GitHub Action no longer including 14 effects ALL packages, even though it isn't directly in their directory tree. Nothing supports 14 any more, so everything is breaking.

The reason not to include it would be that while the above is true, there don't seem to be any tests for this package that would have run in 14, so we never technically supported 14 to begin with?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think bumping it then makes sense. If not, just to make sure, we break something in an unrelated version bump later on.

@koddsson koddsson force-pushed the deprecate-node-14 branch from 5f85257 to 8536ba0 Compare April 3, 2023 16:51
Co-authored-by: Westbrook Johnson <westbrook.johnson@gmail.com>
Copy link
Member

@Westbrook Westbrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!!

@Westbrook Westbrook merged commit 2c2b1bd into modernweb-dev:next Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants