Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate node 14 #2195

Merged
merged 5 commits into from
Apr 4, 2023
Merged

Deprecate node 14 #2195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dd473c4
Deprecate node 14
koddsson Mar 31, 2023
67c0a5c
Add a changeset
koddsson Mar 31, 2023
8536ba0
Update version bumps in changeset
koddsson Apr 1, 2023
9e06ef3
Bump `@web/rollup-plugin-workbox`
koddsson Apr 3, 2023
895ad5c
Update .changeset/fuzzy-terms-push.md
koddsson Apr 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions .changeset/fuzzy-terms-push.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
---
'@web/browser-logs': minor
'@web/config-loader': minor
'@web/dev-server': minor
'@web/dev-server-core': minor
'@web/dev-server-esbuild': minor
'@web/dev-server-hmr': minor
'@web/dev-server-import-maps': minor
'@web/dev-server-legacy': major
'@web/dev-server-rollup': minor
'@web/dev-server-storybook': minor
'@web/parse5-utils': major
'@web/polyfills-loader': major
'@web/rollup-plugin-copy': minor
'@web/rollup-plugin-html': major
'@web/rollup-plugin-import-meta-assets': major
'@web/rollup-plugin-polyfills-loader': major
'rollup-plugin-workbox': minor
'@web/test-runner': minor
'@web/test-runner-browserstack': minor
'@web/test-runner-chrome': minor
'@web/test-runner-cli': minor
'@web/test-runner-commands': minor
'@web/test-runner-core': minor
'@web/test-runner-coverage-v8': minor
'@web/test-runner-junit-reporter': minor
'@web/test-runner-mocha': minor
'@web/test-runner-playwright': minor
'@web/test-runner-puppeteer': minor
'@web/test-runner-saucelabs': minor
'@web/test-runner-selenium': minor
'@web/test-runner-visual-regression': minor
'@web/test-runner-webdriver': minor
---

Set node 16 as the minimum version.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rollup-plugin-workbox isn't included here. It doesn't have tests, so it might not actually be "effected" by this change, even though it is. Anyone have thoughts on this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm probably missing something, but why should it be included in this list?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason to include it would be that the GitHub Action no longer including 14 effects ALL packages, even though it isn't directly in their directory tree. Nothing supports 14 any more, so everything is breaking.

The reason not to include it would be that while the above is true, there don't seem to be any tests for this package that would have run in 14, so we never technically supported 14 to begin with?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think bumping it then makes sense. If not, just to make sure, we break something in an unrelated version bump later on.

4 changes: 2 additions & 2 deletions .github/workflows/verify-browserstack.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@ jobs:
steps:
- uses: actions/checkout@v3

- name: Setup Node 14
- name: Setup Node 16
uses: actions/setup-node@v3
env:
FORCE_COLOR: 0
with:
node-version: '14'
node-version: '16'
cache: 'yarn'

- name: Install dependencies
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/verify-saucelabs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,12 @@ jobs:
steps:
- uses: actions/checkout@v3

- name: Setup Node 14
- name: Setup Node 16
uses: actions/setup-node@v3
env:
FORCE_COLOR: 0
with:
node-version: '14'
node-version: '16'
cache: 'yarn'

- name: Install dependencies
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"url": "https://github.com/modernweb-dev/web.git"
},
"engines": {
"node": "^12.20.0 || ^14.13.1 || >=16.0.0"
"node": ">=16.0.0"
},
"scripts": {
"build": "rimraf --glob packages/*/tsconfig.tsbuildinfo && tsc --build",
Expand Down
2 changes: 1 addition & 1 deletion packages/browser-logs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
}
},
"engines": {
"node": ">=10.0.0"
"node": ">=16.0.0"
},
"scripts": {
"build": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion packages/config-loader/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"homepage": "https://github.com/modernweb-dev/web/tree/master/packages/config-loader",
"main": "src/index.js",
"engines": {
"node": ">=10.0.0"
"node": ">=16.0.0"
},
"scripts": {
"build": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion packages/dev-server-core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
}
},
"engines": {
"node": ">=10.0.0"
"node": ">=16.0.0"
},
"scripts": {
"build": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion packages/dev-server-esbuild/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
}
},
"engines": {
"node": ">=10.0.0"
"node": ">=16.0.0"
},
"scripts": {
"build": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion packages/dev-server-hmr/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
}
},
"engines": {
"node": ">=10.0.0"
"node": ">=16.0.0"
},
"scripts": {
"build": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion packages/dev-server-import-maps/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
}
},
"engines": {
"node": ">=10.0.0"
"node": ">=16.0.0"
},
"scripts": {
"build": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion packages/dev-server-legacy/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
}
},
"engines": {
"node": ">=10.0.0"
"node": ">=16.0.0"
},
"scripts": {
"build": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion packages/dev-server-rollup/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
}
},
"engines": {
"node": ">=10.0.0"
"node": ">=16.0.0"
},
"scripts": {
"test": "mocha \"test/node/**/*.test.ts\" --require ts-node/register",
Expand Down
2 changes: 1 addition & 1 deletion packages/dev-server-storybook/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
}
},
"engines": {
"node": ">=10.0.0"
"node": ">=16.0.0"
},
"scripts": {
"build:wc": "node dist/build/cli.js -c demo/wc/.storybook",
Expand Down
2 changes: 1 addition & 1 deletion packages/dev-server/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
}
},
"engines": {
"node": ">=10.0.0"
"node": ">=16.0.0"
},
"scripts": {
"start": "yarn start:syntax",
Expand Down
2 changes: 1 addition & 1 deletion packages/parse5-utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
}
},
"engines": {
"node": ">=10.0.0"
"node": ">=16.0.0"
},
"scripts": {
"build": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion packages/polyfills-loader/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
}
},
"engines": {
"node": ">=12.0.0"
"node": ">=16.0.0"
},
"scripts": {
"build": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion packages/rollup-plugin-copy/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
}
},
"engines": {
"node": ">=10.0.0"
"node": ">=16.0.0"
},
"scripts": {
"test": "mocha test/**/*.test.js --reporter dot",
Expand Down
2 changes: 1 addition & 1 deletion packages/rollup-plugin-html/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
}
},
"engines": {
"node": ">=12.0.0"
"node": ">=16.0.0"
},
"scripts": {
"demo:mpa": "rm -rf demo/dist && rollup -c demo/mpa/rollup.config.js --watch & yarn serve-demo",
Expand Down
2 changes: 1 addition & 1 deletion packages/rollup-plugin-import-meta-assets/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
}
},
"engines": {
"node": ">=10.0.0"
"node": ">=16.0.0"
},
"scripts": {
"test": "npm run test:node",
Expand Down
2 changes: 1 addition & 1 deletion packages/rollup-plugin-polyfills-loader/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
}
},
"engines": {
"node": ">=12.0.0"
"node": ">=16.0.0"
},
"scripts": {
"test": "mocha test/**/*.test.ts --require ts-node/register",
Expand Down
2 changes: 1 addition & 1 deletion packages/test-runner-browserstack/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
}
},
"engines": {
"node": ">=12.0.0"
"node": ">=16.0.0"
},
"scripts": {
"build": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion packages/test-runner-chrome/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
}
},
"engines": {
"node": ">=12.0.0"
"node": ">=16.0.0"
},
"scripts": {
"build": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion packages/test-runner-cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
}
},
"engines": {
"node": ">=12.0.0"
"node": ">=16.0.0"
},
"scripts": {
"build": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion packages/test-runner-commands/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
}
},
"engines": {
"node": ">=12.0.0"
"node": ">=16.0.0"
},
"scripts": {
"build": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion packages/test-runner-core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"./browser/session.js": "./browser/session.js"
},
"engines": {
"node": ">=12.0.0"
"node": ">=16.0.0"
},
"scripts": {
"build": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion packages/test-runner-coverage-v8/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
}
},
"engines": {
"node": ">=12.0.0"
"node": ">=16.0.0"
},
"scripts": {
"build": "tsc"
Expand Down
2 changes: 1 addition & 1 deletion packages/test-runner-junit-reporter/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
}
},
"engines": {
"node": ">=12.0.0"
"node": ">=16.0.0"
},
"scripts": {
"build": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion packages/test-runner-mocha/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"homepage": "https://github.com/modernweb-dev/web/tree/master/packages/test-runner-mocha",
"main": "dist/standalone.js",
"engines": {
"node": ">=12.0.0"
"node": ">=16.0.0"
},
"scripts": {
"build": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion packages/test-runner-playwright/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
}
},
"engines": {
"node": ">=12.0.0"
"node": ">=16.0.0"
},
"scripts": {
"build": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion packages/test-runner-puppeteer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
}
},
"engines": {
"node": ">=12.0.0"
"node": ">=16.0.0"
},
"scripts": {
"build": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion packages/test-runner-saucelabs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
}
},
"engines": {
"node": ">=12.0.0"
"node": ">=16.0.0"
},
"scripts": {
"build": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion packages/test-runner-selenium/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
}
},
"engines": {
"node": ">=12.0.0"
"node": ">=16.0.0"
},
"scripts": {
"build": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion packages/test-runner-visual-regression/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
}
},
"engines": {
"node": ">=12.0.0"
"node": ">=16.0.0"
},
"scripts": {
"build": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion packages/test-runner-webdriver/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
}
},
"engines": {
"node": ">=12.0.0"
"node": ">=16.0.0"
},
"scripts": {
"build": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion packages/test-runner/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
}
},
"engines": {
"node": ">=12.0.0"
"node": ">=16.0.0"
},
"scripts": {
"build": "tsc",
Expand Down