Skip to content
This repository has been archived by the owner on May 30, 2022. It is now read-only.

CTM has non-connected textures on glass. 1.15.2 OF Preview G1_Pre2 #130

Closed
LyCH-OS opened this issue Feb 15, 2020 · 12 comments
Closed

CTM has non-connected textures on glass. 1.15.2 OF Preview G1_Pre2 #130

LyCH-OS opened this issue Feb 15, 2020 · 12 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@LyCH-OS
Copy link

LyCH-OS commented Feb 15, 2020

Like it says in the title. Heres a gif of the issue.
I've been told it's an OptiFabric issue and not an Optifine one. Hopefully it's not hard to fix.

https://puu.sh/FaWth/6183cc2be2.gif

@LyCH-OS LyCH-OS changed the title CTM has non-connected textures on glass. 1.15.2 OF Preview G2 CTM has non-connected textures on glass. 1.15.2 OF Preview G1_Pre2 Feb 15, 2020
@DonSerrot
Copy link

I've had this happening to me with glass panes since at least 1.14.4. I've not noticed anything like this with regular glass.

@modmuss50
Copy link
Owner

I have no idea why this happens

@modmuss50 modmuss50 added bug Something isn't working help wanted Extra attention is needed labels Feb 16, 2020
@ilepow34
Copy link

ilepow34 commented Feb 17, 2020

It looks like the textures on the "back" side of glass panes (north side when the panes are oriented east-west, east side when they're oriented north-south) are mirrored from their normal texture, which is most noticeable on the end pieces. This only occurs when using OptiFine via OptiFabric.
2020-02-17_17 25 07
2020-02-17_17 25 11
2020-02-17_17 25 20
2020-02-17_17 25 22
2020-02-17_17 25 30
2020-02-17_17 25 31
2020-02-17_17 25 38
2020-02-17_17 25 39

This does not occur when using only OptiFine.
2020-02-17_17 27 55
2020-02-17_17 27 59

It only seems to affect the glass panes, not the other blocks that use connected textures like glass blocks, sandstone, and bookshelves.

@ilepow34
Copy link

For clarity, in the first set of screenshots, I'm running the following:

  • Minecraft 1.15.2
  • Fabric loader 0.7.8 build 184
  • OptiFabric 1.0.0 beta 4
  • Optifine 1.15.2 G1 pre3

@ilepow34
Copy link

ilepow34 commented Feb 18, 2020

After playing around a bit, I've found that this bug was caused by a change in fabric api between builds 197 and 198. This means it would have first been noticed in OptiFabric 0.4.3, the first version to support Minecraft 1.14.4, since its minimum fabric api version was bumped from 0.3.0 build 191 to 0.3.0 build 200. I'll see if I can't track down the associated commit in https://github.com/FabricMC/fabric/

@ilepow34
Copy link

In both sets of screenshots, I'm running Minecraft 1.14.3 with Fabric loader 0.4.8 build 155, OptiFine 1.14.3 F2, and Optifabric 0.4.2.

Fabric API 0.3.0 build 197
2020-02-18_00 54 58
2020-02-18_00 55 08

Fabric API 0.3.0 build 198
2020-02-18_00 56 05
2020-02-18_00 56 13

@modmuss50
Copy link
Owner

I think I have an idea why this isnt working correctally. I dont think Fabric API is adding optifine as a resource pack.

@ilepow34
Copy link

Based on the timestamps on GitHub and CurseForge I think this is the commit that caused it: FabricMC/fabric@7495ea2

Should I open an issue there too?

@modmuss50
Copy link
Owner

I think I need to add optifine as a resource pack ontop of being a mod.

@grn-kunnnn
Copy link

I didn’t understand anything, but when it will fixed?
Sorry for the dumb question.

@modmuss50
Copy link
Owner

I think ive made some progress fixing this.

It did require adding optifine as a fake resource pack, I dont think this will cause any issues:

This fix will be included in the next beta version.

@Mixtongent73
Copy link

The pack used to fix this issue does not allow for users to use the Programmer Art pack.

Chocohead added a commit to Chocohead/OptiFabric that referenced this issue Aug 9, 2020
As fun as adding it in explicitly as a resource pack is, it remains more troublesome than doing what OptiFine tries to do
Fixes modmuss50#130, modmuss50#156, modmuss50#201, modmuss50#218, modmuss50#240, modmuss50#246
lordofpipes pushed a commit to lordofpipes/OptiFabric that referenced this issue Mar 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

6 participants