[2.x] Fix functionality in the section "Categories" of the elements tree #16488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruslan-Aleev
added
pr/review-needed
|
@halftrainedharry - Funny we worked up something for this at the same time! I did so for 3.x though. Perhaps we can review each other's solutions? I'll review yours in the next day or two... |
smg6511
approved these changes
Oct 24, 2023
|
@halftrainedharry - I assume, since you closed this PR, you want me to apply the changes I made for my 3.x PR to a new 2.x PR. Let me know if that's the case or if you're working on it; just don't want to duplicate efforts ;-) |
Yes, that's correct. |
opengeek
added a commit
that referenced
this pull request
Mar 25, 2024
### What does it do? Adds a new tree method to properly extract Element data from the working tree Node. There are three patterns for a Node's id, but only one was being accounted for in the code. Additionally, cleans up code formatting in the affected methods. ### Why is it needed? Within the Categories tree, these actions are currently inoperable: - Element removal - Plugin activation/deactivation ### How to test 1. Create a handful of Elements (at least one of each type), both within a Category and within the root (no Category) 2. Verify the ability to remove each Element (from both the Categories tree and from within the individual Element trees) 3. Verify the ability to activate/deactivate Plugins (from both the Categories tree and from within the individual Element trees) ### Related issue(s)/PR(s) Resolves #16487 for MODX 3.x Related to 2.x solution #16488 --------- Co-authored-by: Jason Coward <jason@opengeek.com>
opengeek
added a commit
that referenced
this pull request
Mar 25, 2024
### What does it do? Adds a new tree method to properly extract Element data from the working tree Node. There are three patterns for a Node's id, but only one was being accounted for in the code. Additionally, cleans up code formatting in the affected methods. ### Why is it needed? Within the Categories tree, these actions are currently inoperable: - Element removal - Plugin activation/deactivation ### How to test 1. Create a handful of Elements (at least one of each type), both within a Category and within the root (no Category) 2. Verify the ability to remove each Element (from both the Categories tree and from within the individual Element trees) 3. Verify the ability to activate/deactivate Plugins (from both the Categories tree and from within the individual Element trees) ### Related issue(s)/PR(s) Resolves #16487 for MODX 3.0.x Related to 2.x solution #16488 Port of 3.x solution #16489 --------- Co-authored-by: Jim Graham <jim@pixelsandstrings.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
In some handler-functions, the information about the clicked item (type and id) gets extracted from the node-ID in the tree.
In most sections, the IDs have the prefix
n_.In the "Categories" section, nodes for other types have the prefix
n_c_instead:revolution/core/model/modx/processors/element/getnodes.class.php
Line 480 in 3f887dc
This is now taken into account.
Why is it needed?
Some context menu items don't work correctly, when executed for element types (other than "Category") in the "Categories" section of the elements tree.
How to test
Go to the section "Categories" in the elements tree and check that the following options (in the context menu) now work:
<type>(for the types "Template", "TV", "Chunk", "Snippet" and "Plugin")<type>here (for the types "Template", "TV", "Chunk", "Snippet" and "Plugin")Related issue(s)/PR(s)
Resolves #16487 for MODX 2.x