Fix Element handling from within Categories tree #16489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smg6511
changed the title
|
@smg6511 would it make sense for you to implement same approach for 2.x? |
It would, I just didn't want to step on any toes, since @halftrainedharry already put up a different solution for 2.x. |
opengeek
added a commit
that referenced
this pull request
Mar 22, 2024
### What does it do? Adds a new tree method to properly extract Element data from the working tree Node. There are three patterns for a Node's id, but only one was being accounted for in the code. Additionally, cleans up code formatting in the affected methods. ### Why is it needed? Within the Categories tree, these actions are currently inoperable: - Element removal - Plugin activation/deactivation ### How to test 1. Create a handful of Elements (at least one of each type), both within a Category and within the root (no Category) 2. Verify the ability to remove each Element (from both the Categories tree and from within the individual Element trees) 3. Verify the ability to activate/deactivate Plugins (from both the Categories tree and from within the individual Element trees) ### Related issue(s)/PR(s) Resolves #16487 for MODX 2.x Port of PR #16489 --------- Co-authored-by: Jason Coward <jason@opengeek.com>
smg6511
added
pr/ready-for-merging
Fix contextual menu action functionality within Categories tree
Refactor new extraction method to account for Element creation in the root of its tree
opengeek
force-pushed
the
3.x-issue-16487
branch
from
3a21a32 to
481571f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.x #16489 +/- ##
=========================================
Coverage 21.57% 21.57%
- Complexity 10568 10573 +5
=========================================
Files 561 561
Lines 31940 31966 +26
=========================================
+ Hits 6892 6898 +6
- Misses 25048 25068 +20 ☔ View full report in Codecov by Sentry. |
opengeek
added a commit
that referenced
this pull request
Mar 25, 2024
### What does it do? Adds a new tree method to properly extract Element data from the working tree Node. There are three patterns for a Node's id, but only one was being accounted for in the code. Additionally, cleans up code formatting in the affected methods. ### Why is it needed? Within the Categories tree, these actions are currently inoperable: - Element removal - Plugin activation/deactivation ### How to test 1. Create a handful of Elements (at least one of each type), both within a Category and within the root (no Category) 2. Verify the ability to remove each Element (from both the Categories tree and from within the individual Element trees) 3. Verify the ability to activate/deactivate Plugins (from both the Categories tree and from within the individual Element trees) ### Related issue(s)/PR(s) Resolves #16487 for MODX 3.0.x Related to 2.x solution #16488 Port of 3.x solution #16489 --------- Co-authored-by: Jim Graham <jim@pixelsandstrings.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Adds a new tree method to properly extract Element data from the working tree Node. There are three patterns for a Node's id, but only one was being accounted for in the code. Additionally, cleans up code formatting in the affected methods.
Why is it needed?
Within the Categories tree, these actions are currently inoperable:
How to test
Related issue(s)/PR(s)
Resolves #16487 for MODX 3.x
Related to 2.x solution #16488