Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Fix Element handling from within Categories tree #16492

Closed
wants to merge 1 commit into from

Conversation

jimg6511
Copy link

What does it do?

Adds a new tree method to properly extract Element data from the working tree Node. There are three patterns for a Node's id, but only one was being accounted for in the code. Additionally, cleans up code formatting in the affected methods.

Why is it needed?

Within the Categories tree, these actions are currently inoperable:

  • Element removal
  • Plugin activation/deactivation

How to test

  1. Create a handful of Elements (at least one of each type), both within a Category and within the root (no Category)
  2. Verify the ability to remove each Element (from both the Categories tree and from within the individual Element trees)
  3. Verify the ability to activate/deactivate Plugins (from both the Categories tree and from within the individual Element trees)

Related issue(s)/PR(s)

Provide any issue that's addressed by this change in the format "Resolves #", and mention other issues/pull requests with relevant information.

Related issue(s)/PR(s)
Resolves #16487 for MODX 2.x
Port of PR #16489

@jimg6511
Copy link
Author

Resubmitted this under my regular GitHub account. See #16493.

@jimg6511 jimg6511 closed this Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant