Skip to content

Conversation

@smg6511
Copy link
Collaborator

@smg6511 smg6511 commented May 22, 2025

What does it do?

Makes array checking strict in the method used for evaluating boolean option types.

Why is it needed?

Autogrow and Resizable option settings were not displaying/saving correctly.

I have no idea how/why this issue did not crop up when these options were added originally, not too long ago :-/

How to test

Create a textarea TV and change these input options to verify they persist as expected.

Related issue(s)/PR(s)

Resolves #16746

Make array checking strict
@smg6511 smg6511 requested review from Mark-H and opengeek as code owners May 22, 2025 04:21
Copy link
Member

@theboxer theboxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@opengeek opengeek changed the title FIx Textarea TV Input Options Fix Textarea TV Input Options Nov 4, 2025
@opengeek opengeek merged commit a94a0f6 into modxcms:3.x Nov 4, 2025
7 checks passed
@opengeek opengeek added this to the v3.2.0 milestone Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Textarea TV loses Auto Grow and Resizable settings on reload

4 participants