Skip to content

Fix Textarea TV Input Options #16747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2025
Merged

Fix Textarea TV Input Options #16747

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/Revolution/modX.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,16 +400,16 @@

/**
* Evaluate boolean-like parameter value and return it as an actual boolean or as a string; a string may be
* needed/preferred when building code blocks (e.g., javascript) via php strings (nowdoc/heredoc ones in particular).

Check warning on line 403 in core/src/Revolution/modX.php

View workflow job for this annotation

GitHub Actions / phpcs 

Line exceeds 120 characters; contains 121 characters
*
* @param array $params An associative or numeric-indexed array of parameters
* @param string|int $key The array key to evaluate
* @param bool $returnBoolAsString Whether to return the string representation ('true' or 'false') of the boolean value

Check warning on line 407 in core/src/Revolution/modX.php

View workflow job for this annotation

GitHub Actions / phpcs 

Line exceeds 120 characters; contains 123 characters
* @return string|bool
*/
public function paramValueIsTrue(array $params, $key, bool $returnBoolAsString = false)
{
if (isset($params[$key]) && in_array($params[$key], ['true', true, '1', 1])) {
if (isset($params[$key]) && in_array($params[$key], ['true', true, '1', 1], true)) {
return $returnBoolAsString ? 'true' : true ;
}
return $returnBoolAsString ? 'false' : false ;
Expand Down