Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[joss-reviews#2974] Python and dependencies version compatibility are missing #10

Closed
chkoar opened this issue Feb 6, 2021 · 5 comments · Fixed by #39
Closed

[joss-reviews#2974] Python and dependencies version compatibility are missing #10

chkoar opened this issue Feb 6, 2021 · 5 comments · Fixed by #39
Assignees
@chkoar
Labels
Ready for JOSS review

Comments

@chkoar
Copy link
Contributor

chkoar commented Feb 6, 2021 •
edited
Loading

Related: openjournals/joss-reviews#2974

Docs should state the minimum (and the expected maximum) required versions so the package would be able to work.
@chkoar chkoar mentioned this issue Feb 6, 2021
Closed
@geoffreyp
Copy link
Contributor

Documentation updated, Readme updated on dev branch

@chkoar
Copy link
Contributor Author

chkoar commented Feb 11, 2021

As I can see the package requires numpy. Although, I cannot see a minimum required version for numpy. Does this mean that it can work with any version of numpy?

@chkoar
Copy link
Contributor Author

chkoar commented Feb 11, 2021

Classifiers for the supported python versions could be added in the setup.py

geoffreyp added a commit that referenced this issue Feb 11, 2021
@geoffreyp
issue #10
1624f90
@geoffreyp
Copy link
Contributor

Documentation updated: https://moead-framework.github.io/framework/html/install.html
setup.py: https://github.com/moead-framework/framework/blob/master/setup.py
requirements.txt: https://github.com/moead-framework/framework/blob/master/requirements.txt

@sjvrijn sjvrijn mentioned this issue Mar 29, 2021
Merged
@chkoar
Copy link
Contributor Author

chkoar commented Mar 29, 2021

Can be closed after #39

@geoffreyp geoffreyp linked a pull request Mar 30, 2021 that will close this issue
Reference requirements.txt in setup #39
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chkoar chkoar

Labels
Ready for JOSS review
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reference requirements.txt in setup
2 participants
@geoffreyp @chkoar