Fix autoblack workflow for forks #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ached head keep to v2 to be minimal
if we have no changes to commit then we shouldn't need to run the commit command anyway
|
Hey @ADBond is there a reason why you are only changing to v2 when there is a v3 available? |
Not particularly - just that v2 was the change that brought the fix (and initially hadn't realised v3 was available). Didn't change as atm we have a mix of v2 and v3 in the repo, and figured it would be useful at some stage to standardise some of this stuff (maybe with some reusable bits of workflows and the like). Happy to bump it up to v3 though |
|
Ah ok, I hadn't checked the other bits of the repo. Probably better to have some consistency. Happy to go with v2 for now then we can upgrade everything in one go at a later stage |
RossKen
approved these changes
Mar 23, 2023
This was referenced Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the autoblack workflow to use an updated version of the
checkoutaction. This means that the checkout is not in a 'detached head' state which necessitated the need for correcting the git ref of the PR head, which would fail if the PR is from a forked repo.The workflow will still fail for forks if there are linting changes which need to be made (and thus will need to be performed manually by the contributor), but it should pass if the code is black-conformant, and so the failure/passing of this workflow will at least be informative.
Additionally a couple of minor changes.
Fixes #1124