Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix autoblack checkout step #1169

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Fix autoblack checkout step #1169

merged 1 commit into from
Apr 11, 2023

Conversation

ADBond
Copy link
Contributor

@ADBond ADBond commented Apr 3, 2023

Moving to github actions checkout in #1133 has left the state as a detached head in the autoblack workflow, meaning the push step fails. This changes the checkout parameters to correct the git state, so that changes can be pushed.

@ADBond ADBond mentioned this pull request Apr 3, 2023
Closed
@ADBond
Copy link
Contributor Author

ADBond commented Apr 3, 2023

As per #1133 the workflow will fail on forks if linting changes are needed, but will pass if there are no changes required - thus the workflow is informative. See #1170 for example - failure is at push step due to permissions only.

Should run fine either way within this repo in branches.

@ADBond ADBond requested a review from RossKen April 11, 2023 08:14
RossKen
RossKen approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@RossKen RossKen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ADBond ADBond merged commit fd287e7 into moj-analytical-services:master Apr 11, 2023
@ADBond ADBond deleted the fix-autoblack-ref branch April 11, 2023 10:31
@ADBond ADBond mentioned this pull request Apr 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RossKen RossKen RossKen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ADBond @RossKen