-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEPS] Backend installs #1554
[DEPS] Backend installs #1554
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some tabs to make the docs render better but otherwise good to go from me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sorry, hadn't spotted test failures
Thanks @RossKen, I'll sort the dependency woes in the morning. |
…r_py_3.7 Drop support for py 3.7
@RossKen I've updated a few things to allow pandas 2.0 and up to work with Splink. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 👏
Type of PR
Is your Pull Request linked to an existing Issue or Pull Request?
Referenced in #1245
Give a brief description for the solution you have provided
Adds support for optional installs for our various backends.
Moving forward, users will be able to install all backend specific installs by using the syntax:
pip install 'splink[<backend>]'
instead of installing splink and then installing any additional requirements from there.
I've edited the bash script
test_poetry_installs.sh
so you can easily test that this is installing what we're expecting it to.PR Checklist