Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEPS] Backend installs #1554

Merged
merged 20 commits into from
Sep 15, 2023
Merged

[DEPS] Backend installs #1554

merged 20 commits into from
Sep 15, 2023

Conversation

ThomasHepworth
Copy link
Contributor

Type of PR

  • BUG
  • FEAT
  • MAINT
  • DOC

Is your Pull Request linked to an existing Issue or Pull Request?

Referenced in #1245

Give a brief description for the solution you have provided

Adds support for optional installs for our various backends.

Moving forward, users will be able to install all backend specific installs by using the syntax:

pip install 'splink[<backend>]'

instead of installing splink and then installing any additional requirements from there.

I've edited the bash script test_poetry_installs.sh so you can easily test that this is installing what we're expecting it to.

PR Checklist

  • Added documentation for changes
  • Added feature to example notebooks or tutorial (if appropriate)
  • Added tests (if appropriate)
  • Made changes based off the latest version of Splink
  • Run the linter

Copy link
Contributor

@RossKen RossKen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some tabs to make the docs render better but otherwise good to go from me

Copy link
Contributor

@RossKen RossKen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry, hadn't spotted test failures

@ThomasHepworth
Copy link
Contributor Author

Thanks @RossKen, I'll sort the dependency woes in the morning.

@ThomasHepworth
Copy link
Contributor Author

@RossKen I've updated a few things to allow pandas 2.0 and up to work with Splink.

Copy link
Contributor

@RossKen RossKen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👏

@RossKen RossKen merged commit 52668b4 into master Sep 15, 2023
@RossKen RossKen deleted the backend_installs branch September 15, 2023 09:13
@ThomasHepworth ThomasHepworth changed the title Backend installs [DEPS] Backend installs Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants