Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEPS] Drop support for py 3.7 #1600

Merged
merged 6 commits into from
Sep 13, 2023

Conversation

ThomasHepworth
Copy link
Contributor

@ThomasHepworth ThomasHepworth commented Sep 12, 2023

Drops support for python3.7.

We've had long standing dependency issues due to pandas and awswrangler not supporting py 3.7 and it's a major blocker in #1554.

If this is an issue for users, we can either:

  • Undo this PR and reimplement support
  • Tell users to use Splink <=3.9.6. If this becomes a common theme, we may want to prioritise getting docs versioning sorted.

See here for some further reasoning behind this change - https://pythonspeed.com/articles/stop-using-python-3.7/.

@RossKen
Copy link
Contributor

RossKen commented Sep 12, 2023

This all makes sense to me - can you add a caveat about dropping support into the docs and I will approve?

@RossKen
Copy link
Contributor

RossKen commented Sep 12, 2023

This all makes sense to me - can you add a caveat about dropping support into the docs and I will approve?

E.g. in "getting started" we quote 3.7+

Copy link
Contributor

@RossKen RossKen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding - good to go! 🎉

@ThomasHepworth ThomasHepworth merged commit 1f82e34 into backend_installs Sep 13, 2023
2 checks passed
@ThomasHepworth ThomasHepworth deleted the drop_support_for_py_3.7 branch September 13, 2023 09:33
@ThomasHepworth ThomasHepworth changed the title Drop support for py 3.7 [DEPS] Drop support for py 3.7 Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants