Code

More unit tests and some code cleanup#87

Code

Merged

vbarzokas merged 48 commits intomojaloop:mastermojaloop/quoting-service:masterfrom vbarzokas:masterCopy head branch name to clipboardNov 20, 2019

+2,091-1,221

Commits

Commits on Sep 23, 2019

• Tests converted to Jest

  partiallyordered

  committed
  53f1b03

  Copy full SHA for 53f1b03

• Added rules engine jsonpath dynamic fact

  partiallyordered

  committed
  26cc810

  Copy full SHA for 26cc810

Commits on Sep 24, 2019

• Updated rules engine API. Added jsonpath package to dependencies. Added rules engine tests. Added Jest config. Added example rules.json.

  partiallyordered

  committed
  ee5f780

  Copy full SHA for ee5f780

• Updated hapi/subtext to patch vulnerability

  partiallyordered

  committed
  7cbbe92

  Copy full SHA for 7cbbe92

• Updated example rules and corresponding tests to reflect real form of payer and payee

  partiallyordered

  committed
  c0ce090

  Copy full SHA for c0ce090

Commits on Sep 25, 2019

• Added switch endpoint to config to obtain payer and payee information for rules engine. Stubbed validateQuoteRequest method in relevant tests. Running rules engine in validateQuoteRequest (but not …

  Show description for ae4a017
  partiallyordered

  committed
  ae4a017

  Copy full SHA for ae4a017

• Tests converted to Jest

  partiallyordered

  committed
  52e7f2f

  Copy full SHA for 52e7f2f

• Replaced coverage-check script. Added coverage threshold to jest config. Removed Istanbul config.

  partiallyordered

  committed
  c51c04d

  Copy full SHA for c51c04d

• Uninstalled and reinstalled jest to fix vulnerability

  partiallyordered

  committed
  b3ed58b

  Copy full SHA for b3ed58b

• Added junit + config. Added test:junit npm script. Modified circle config to call junit script. Added test results directory to gitignore.

  partiallyordered

  committed
  dc1e922

  Copy full SHA for dc1e922

• Merge remote-tracking branch 'msk-/test-with-jest'

  partiallyordered

  committed
  a2027f3

  Copy full SHA for a2027f3

• Modified example rules and corresponding tests to better reflect actual payer and payee facts

  partiallyordered

  committed
  7d006cd

  Copy full SHA for 7d006cd

• Merge remote-tracking branch 'origin/master'

  partiallyordered

  committed
  293fbf4

  Copy full SHA for 293fbf4

Commits on Oct 24, 2019

• Updated redirect address to redirect fsp. Made the linter happy. Added rule execution and event handling. Removed empty quote validation, replaced with rules engine execution. Removed redundant set…

  Show description for b9aec14
  partiallyordered

  committed
  b9aec14

  Copy full SHA for b9aec14

Commits on Oct 25, 2019

• Merged upstream into fork

  partiallyordered

  committed
  271e28f

  Copy full SHA for 271e28f

Commits on Nov 7, 2019

• Merge conflicts resolved

  partiallyordered

  committed
  4b4acff

  Copy full SHA for 4b4acff

• Manual merge from upstream

  partiallyordered

  committed
  d830523

  Copy full SHA for d830523

Commits on Nov 8, 2019

• Integrated properly the new model/rules.js into model/quotes.js and updated the quotes.tests.js accordingly.

  

  Vassilis Barzokas

  committed
  9ddfa59

  Copy full SHA for 9ddfa59

• Simplified block of code that was unnecessarily using map.

  

  Vassilis Barzokas

  committed
  5cc9bba

  Copy full SHA for 5cc9bba

• Merge pull request #1 from vbarzokas/bugfix/integrate-rules-engine-fix-unit-tests

  Show description for 1dc5496
  partiallyordered

  authored
  1dc5496

  Copy full SHA for 1dc5496

• Forwarding event-handler-modified quote request and headers instead of originals

  partiallyordered

  committed
  9f8df68

  Copy full SHA for 9f8df68

• Fixed tests by poorly mocking handleRuleEvents on the quotes model

  partiallyordered

  committed
  bc17ba5

  Copy full SHA for bc17ba5

• Cleaned a little bit the result of handleRuleEvents;

  Show description for c967661
  

  Vassilis Barzokas

  committed
  c967661

  Copy full SHA for c967661

Commits on Nov 11, 2019

• Merge pull request #2 from vbarzokas/bugfix/update-unit-tests

  Show description for 75b879f
  partiallyordered

  authored
  75b879f

  Copy full SHA for 75b879f

• Deduplicated the functionality of request sending

  

  Vassilis Barzokas

  committed
  5bcb954

  Copy full SHA for 5bcb954

• Removed setImmediate from all places that it was used.

  

  Vassilis Barzokas

  committed
  6e82010

  Copy full SHA for 6e82010

• Use CreateInternalServerFSPIOPError instead of CreateFSPIOPError

  

  Vassilis Barzokas

  committed
  b0444a5

  Copy full SHA for b0444a5

Commits on Nov 12, 2019

• Merge pull request #3 from vbarzokas/feature/cleanup-code

  Show description for 87ec59c
  partiallyordered

  authored
  87ec59c

  Copy full SHA for 87ec59c

Commits on Nov 13, 2019

• fixed the name of rules.json

  shashi165

  authored
  c672359

  Copy full SHA for c672359

Commits on Nov 14, 2019

• rename file rules.example.json

  

  shashi165

  committed
  ff6ad79

  Copy full SHA for ff6ad79

• Refactored existing unit tests in order to make them cleaner and avoid duplication;

  Show description for 77615fd
  

  Vassilis Barzokas

  committed
  77615fd

  Copy full SHA for 77615fd

• Refactored handleQuoteRequest to make it more readable and avoid duplication;

  Show description for acf5930
  

  Vassilis Barzokas

  committed
  acf5930

  Copy full SHA for acf5930

• Merge pull request #4 from shashi165/patch-1

  Show description for 7390131
  partiallyordered

  authored
  7390131

  Copy full SHA for 7390131

• Merge branch 'master' into feature/more-unit-tests

  partiallyordered

  authored
  d7d727d

  Copy full SHA for d7d727d

• Resolved issue with merge

  partiallyordered

  committed
  b7f7159

  Copy full SHA for b7f7159

• Added unit tests for quotesModel.handleRuleEvents

  

  Vassilis Barzokas

  committed
  b37a090

  Copy full SHA for b37a090

Commits on Nov 15, 2019

• Minor update to behaviour and corresponding test update. Minor test change.

  partiallyordered

  committed
  378169f

  Copy full SHA for 378169f

• Lint fix

  partiallyordered

  committed
  d279d1a

  Copy full SHA for d279d1a

• Added unit tests for quotesModel.executeRules

  

  Vassilis Barzokas

  committed
  a12df29

  Copy full SHA for a12df29

• Added more unit tests to quotesModel.executeRules to cover rejected promises of axios.request

  

  Vassilis Barzokas

  committed
  c5eb216

  Copy full SHA for c5eb216

• Minor refactoring on the unit tests of RulesEngine to use describe blocks and it() instead of test() for consistency.

  

  Vassilis Barzokas

  committed
  48917d6

  Copy full SHA for 48917d6

Commits on Nov 17, 2019

• Merge pull request #5 from vbarzokas/feature/more-unit-tests

  Show description for 29785fd
  partiallyordered

  authored
  29785fd

  Copy full SHA for 29785fd

Commits on Nov 18, 2019

• Merge branch 'master' of https://github.com/mojaloop/quoting-service

  Show description for 5dc2c3f
  

  Vassilis Barzokas

  committed
  5dc2c3f

  Copy full SHA for 5dc2c3f

Commits on Nov 20, 2019

• Merged changes from upstream

  

  Vassilis Barzokas

  committed
  f48ffb1

  Copy full SHA for f48ffb1

• Added missing dependency that got removed after merging.

  

  Vassilis Barzokas

  committed
  fffd056

  Copy full SHA for fffd056

• Updated quotes model unit tests to match the new implementation of config.js

  

  Vassilis Barzokas

  committed
  1582a90

  Copy full SHA for 1582a90

• Updated comments in codebase.

  

  Vassilis Barzokas

  committed
  db08654

  Copy full SHA for db08654

• Removed `^ sign from dependency in package.json

  

  Vassilis Barzokas

  committed
  9bc0b98

  Copy full SHA for 9bc0b98