Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mojaloop/#2880): simplify liquidity cover check and fix issue with validation (master) #85

Commits on Aug 25, 2022

  1. feat(mojaloop/#2880): simplify liquidity cover check and fix issue wi…

    …th validation
    
    feat(mojaloop/#2880): simplify liquidity cover check and fix issue with validation - mojaloop/project#2880
    - fixes to collections/hub/golden_path/feature_tests/block_transfers
      - aligned liquidity and position calculations with central-ledger logic
      - cleaned up unecessary requests (i.e. why have two requests to fetch settlement and position accounts when it can be done in one?)
    mdebarros committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    2daf63c View commit details
    Browse the repository at this point in the history
  2. improvements to CGS test cases

    - cleaned up test-scripts, and aligned them to central-ledger changes
    - added new env var environment.SETTLEMENT_RULE_INTERCHANGE_FEE which defaults to '0.006' (ref: https://github.com/mojaloop/central-settlement/blob/master/scripts/transferSettlementTemp/interchangeFeeCalculation.js#L47)
    - updated script logic to correctly calculate interchange-fees based on the provided environment.SETTLEMENT_RULE_INTERCHANGE_FEE
    mdebarros committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    3a7acae View commit details
    Browse the repository at this point in the history
  3. fixes for CGS

    mdebarros committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    5406642 View commit details
    Browse the repository at this point in the history
  4. several updates and improvements to settlement cgs test-cases

    - re-factored `[new sims] transfers, positions CGS Window1 tests (OTC-649, OTC-645)`
      - standardised naming convention
      - re-aligned position, settlement and interchange checks, and expanded on checks dynamically based on the transfer amounts (Tx1, Tx2, Tx3, Tx4, Tx5, Tx6) instead of using "hard-coded" values
      - added new OPTIONAL env vars for:
        1. SETTLEMENT_CGS_TX_AMOUNT_1 (defaults: 15), SETTLEMENT_CGS_TX_AMOUNT_2 (defaults: 87.88), SETTLEMENT_CGS_TX_AMOUNT_3 (defaults: 158.36), SETTLEMENT_CGS_TX_AMOUNT_4 (defaults: 211.11), SETTLEMENT_CGS_TX_AMOUNT_5 (defaults: 14.05), SETTLEMENT_CGS_TX_AMOUNT_6 (defaults: 150) representing the transfer amounts for each Transaction. These correlate to Tx1...Tx6
        2. SETTLEMENT_RULE_INTERCHANGE_FEE (defaults: 0.006) which is the Interchange Fee % used to calculate the aggregate Fee
    mdebarros committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    8ff2170 View commit details
    Browse the repository at this point in the history
  5. removed unnecessary duplicate position check (since we consolidated c…

    …hecks) and fixed test-case naming/meta-data
    mdebarros committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    6bdd9f9 View commit details
    Browse the repository at this point in the history
  6. same as before

    - removed duplicate test-cases
    - fixed names for consistency
    mdebarros committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    6b876c4 View commit details
    Browse the repository at this point in the history
  7. Merge branch 'master' of github.com:mojaloop/testing-toolkit-test-cas…

    …es into feat/#2880-Simplify-liquidity-cover-check-and-fix-issue-with-validation
    mdebarros committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    62280d9 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2022

  1. updates for test-cases

    - added p2p happy path with balance checks (position, settlement, and reserved balances)
    - fixed issue in block transfers to ensure that the amount removes trailing spaces by converting a number converted to a fixed string back into a number to drop any trailing zeros: Number(Number.toFixed(2))
    - updated some descriptions/meta for newsetcgs test-cases
    mdebarros committed Aug 26, 2022
    Configuration menu
    Copy the full SHA
    bcb7d00 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2022

  1. Revert "Merge branch 'master' of github.com:mojaloop/testing-toolkit-…

    …test-cases into feat/#2880-Simplify-liquidity-cover-check-and-fix-issue-with-validation"
    
    This reverts commit 62280d9, reversing
    changes made to 6b876c4.
    mdebarros committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    eea9005 View commit details
    Browse the repository at this point in the history
  2. chore: added "Deposit Funds into Settlement Account (Funds-In)" test-…

    …case
    
    - added funds-in for testfsp's 1,2,3 and 4
    - added new optional environment parameters for each testfsp: SETTLEMENT_CGS_FUNDSIN_TESTFSP1, SETTLEMENT_CGS_FUNDSIN_TESTFSP2, SETTLEMENT_CGS_FUNDSIN_TESTFSP3, SETTLEMENT_CGS_FUNDSIN_TESTFSP4 - with defaults of 2000
    mdebarros committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    49ea150 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2022

  1. chore: added balance checks before and after funds-in for CGS test-cases

    - check to see settlement-balance has increased by the funds-in amount for testfsp 1, 2, 3 & 4
    mdebarros committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    272ef06 View commit details
    Browse the repository at this point in the history
  2. chore: maintenance

    - disabled duplicate Get Balance requests for CGS tests, and added comment indicating that they are disabled by default but useful for debugging issues.
    mdebarros committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    e3dccdc View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. fixes for settlement cgs ttk tests

    - removed duplicate tests (possible bug in TTK)
    mdebarros committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    9304fa9 View commit details
    Browse the repository at this point in the history
  2. Revert "fixes for settlement cgs ttk tests"

    This reverts commit 9304fa9.
    mdebarros committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    c66d5ef View commit details
    Browse the repository at this point in the history