-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mojaloop/#2880): simplify liquidity cover check and fix issue with validation (master) #85
Commits on Aug 25, 2022
-
feat(mojaloop/#2880): simplify liquidity cover check and fix issue wi…
…th validation feat(mojaloop/#2880): simplify liquidity cover check and fix issue with validation - mojaloop/project#2880 - fixes to collections/hub/golden_path/feature_tests/block_transfers - aligned liquidity and position calculations with central-ledger logic - cleaned up unecessary requests (i.e. why have two requests to fetch settlement and position accounts when it can be done in one?)
Configuration menu - View commit details
-
Copy full SHA for 2daf63c - Browse repository at this point
Copy the full SHA 2daf63cView commit details -
improvements to CGS test cases
- cleaned up test-scripts, and aligned them to central-ledger changes - added new env var environment.SETTLEMENT_RULE_INTERCHANGE_FEE which defaults to '0.006' (ref: https://github.com/mojaloop/central-settlement/blob/master/scripts/transferSettlementTemp/interchangeFeeCalculation.js#L47) - updated script logic to correctly calculate interchange-fees based on the provided environment.SETTLEMENT_RULE_INTERCHANGE_FEE
Configuration menu - View commit details
-
Copy full SHA for 3a7acae - Browse repository at this point
Copy the full SHA 3a7acaeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5406642 - Browse repository at this point
Copy the full SHA 5406642View commit details -
several updates and improvements to settlement cgs test-cases
- re-factored `[new sims] transfers, positions CGS Window1 tests (OTC-649, OTC-645)` - standardised naming convention - re-aligned position, settlement and interchange checks, and expanded on checks dynamically based on the transfer amounts (Tx1, Tx2, Tx3, Tx4, Tx5, Tx6) instead of using "hard-coded" values - added new OPTIONAL env vars for: 1. SETTLEMENT_CGS_TX_AMOUNT_1 (defaults: 15), SETTLEMENT_CGS_TX_AMOUNT_2 (defaults: 87.88), SETTLEMENT_CGS_TX_AMOUNT_3 (defaults: 158.36), SETTLEMENT_CGS_TX_AMOUNT_4 (defaults: 211.11), SETTLEMENT_CGS_TX_AMOUNT_5 (defaults: 14.05), SETTLEMENT_CGS_TX_AMOUNT_6 (defaults: 150) representing the transfer amounts for each Transaction. These correlate to Tx1...Tx6 2. SETTLEMENT_RULE_INTERCHANGE_FEE (defaults: 0.006) which is the Interchange Fee % used to calculate the aggregate Fee
Configuration menu - View commit details
-
Copy full SHA for 8ff2170 - Browse repository at this point
Copy the full SHA 8ff2170View commit details -
removed unnecessary duplicate position check (since we consolidated c…
…hecks) and fixed test-case naming/meta-data
Configuration menu - View commit details
-
Copy full SHA for 6bdd9f9 - Browse repository at this point
Copy the full SHA 6bdd9f9View commit details -
- removed duplicate test-cases - fixed names for consistency
Configuration menu - View commit details
-
Copy full SHA for 6b876c4 - Browse repository at this point
Copy the full SHA 6b876c4View commit details -
Merge branch 'master' of github.com:mojaloop/testing-toolkit-test-cas…
…es into feat/#2880-Simplify-liquidity-cover-check-and-fix-issue-with-validation
Configuration menu - View commit details
-
Copy full SHA for 62280d9 - Browse repository at this point
Copy the full SHA 62280d9View commit details
Commits on Aug 26, 2022
-
- added p2p happy path with balance checks (position, settlement, and reserved balances) - fixed issue in block transfers to ensure that the amount removes trailing spaces by converting a number converted to a fixed string back into a number to drop any trailing zeros: Number(Number.toFixed(2)) - updated some descriptions/meta for newsetcgs test-cases
Configuration menu - View commit details
-
Copy full SHA for bcb7d00 - Browse repository at this point
Copy the full SHA bcb7d00View commit details
Commits on Aug 31, 2022
-
Revert "Merge branch 'master' of github.com:mojaloop/testing-toolkit-…
Configuration menu - View commit details
-
Copy full SHA for eea9005 - Browse repository at this point
Copy the full SHA eea9005View commit details -
chore: added "Deposit Funds into Settlement Account (Funds-In)" test-…
…case - added funds-in for testfsp's 1,2,3 and 4 - added new optional environment parameters for each testfsp: SETTLEMENT_CGS_FUNDSIN_TESTFSP1, SETTLEMENT_CGS_FUNDSIN_TESTFSP2, SETTLEMENT_CGS_FUNDSIN_TESTFSP3, SETTLEMENT_CGS_FUNDSIN_TESTFSP4 - with defaults of 2000
Configuration menu - View commit details
-
Copy full SHA for 49ea150 - Browse repository at this point
Copy the full SHA 49ea150View commit details
Commits on Sep 2, 2022
-
chore: added balance checks before and after funds-in for CGS test-cases
- check to see settlement-balance has increased by the funds-in amount for testfsp 1, 2, 3 & 4
Configuration menu - View commit details
-
Copy full SHA for 272ef06 - Browse repository at this point
Copy the full SHA 272ef06View commit details -
- disabled duplicate Get Balance requests for CGS tests, and added comment indicating that they are disabled by default but useful for debugging issues.
Configuration menu - View commit details
-
Copy full SHA for e3dccdc - Browse repository at this point
Copy the full SHA e3dccdcView commit details
Commits on Sep 6, 2022
-
fixes for settlement cgs ttk tests
- removed duplicate tests (possible bug in TTK)
Configuration menu - View commit details
-
Copy full SHA for 9304fa9 - Browse repository at this point
Copy the full SHA 9304fa9View commit details -
Revert "fixes for settlement cgs ttk tests"
This reverts commit 9304fa9.
Configuration menu - View commit details
-
Copy full SHA for c66d5ef - Browse repository at this point
Copy the full SHA c66d5efView commit details