Debug/mapping uuids #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LoyVanBeek
force-pushed
the
debug/mapping_uuids
branch
from
9b87923 to
78c5681
Compare
…e applied In determine_field_mapping, there was an early return inside a loop over all mapping rules. IF there we any mapping rules but they don't specify field mappings, the early return made the function return without creating mappings automatically. For a particular message type, ROS 1's uuid_msgs/UniqueID vs ROS 2's unique_identifier_msgs/UUID, the message definition is exacly the same but type name is not. The only mapping fule defined in for unique_identifier_msgs/UUID is that it maps to uuid_msgs/UniqueID, but no field mappings are needed because the definitions are the same. But, then we hit the early return (because the for-loop is exhausted without applying any rule and thus not `continue`-ing in a code branch handling a rule) and return without applying the normal automatic field mapping generation rules. By removing the early return, the other rules are applied and the mapping rules for handling the exact same message defintions are applied
…to focus on for debugging
…s gathered so far
…os1, also check the existing such mappings
… is dependency tracking somehow?
…os2 to ros1, also check the existing such mappings" This reverts commit bccc807.
LoyVanBeek
force-pushed
the
debug/mapping_uuids
branch
from
78c5681 to
e707c7c
Compare
Merged
|
Failing tests in CI seem to only complain about formatting and not about functionality, although they don't test the stuff this PR tries to fix. I'll go ahead and extract the beef of my patch and cut the debugging prints. |
…be compiled correctly
…n) code generated but the mapping itself returns None
|
merge #9 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #4 Do not merge this, if this passes, I need to clean it up and provide a smaller patch also to upstream. This is for CI & testing only