Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature parametrize qos #1

Closed

Conversation

LoyVanBeek
Copy link
Member

@LoyVanBeek LoyVanBeek commented Oct 28, 2021

LoyVanBeek and others added 14 commits October 18, 2021 15:02
Signed-off-by: Loy van Beek <loy.vanbeek@mojin-robotics.de>
Signed-off-by: Loy van Beek <loy.vanbeek@mojin-robotics.de>
Signed-off-by: Loy van Beek <loy.vanbeek@mojin-robotics.de>
Signed-off-by: Loy van Beek <loy.vanbeek@mojin-robotics.de>
Signed-off-by: Loy van Beek <loy.vanbeek@mojin-robotics.de>
Signed-off-by: Loy van Beek <loy.vanbeek@mojin-robotics.de>
Signed-off-by: Loy van Beek <loy.vanbeek@mojin-robotics.de>
Signed-off-by: Loy van Beek <loy.vanbeek@mojin-robotics.de>
Signed-off-by: Loy van Beek <loy.vanbeek@mojin-robotics.de>
…representation of liveliness enum values

Signed-off-by: Loy van Beek <loy.vanbeek@mojin-robotics.de>
Signed-off-by: Loy van Beek <loy.vanbeek@mojin-robotics.de>
In 2 cases the formatting conflicts with what uncrustify wants; // NOLINT got rid of the complaints of cpplint, favouring uncrustify

Signed-off-by: Loy van Beek <loy.vanbeek@mojin-robotics.de>
Co-authored-by: Geoffrey Biggs <gbiggs@killbots.net>
Signed-off-by: Loy van Beek <loy.vanbeek@mojin-robotics.de>
Signed-off-by: Loy van Beek <loy.vanbeek@mojin-robotics.de>
@LoyVanBeek LoyVanBeek force-pushed the feature-parametrize-qos branch from 015e284 to ec44770 Compare November 23, 2021 07:01
@fmessmer
Copy link
Member

fmessmer commented Jul 1, 2022

as ros2#331 is merged upstream, this is obsolete now
I'll update our branches to be harmonized with https://github.com/ros2/ros1_bridge

@fmessmer fmessmer closed this Jul 1, 2022
@fmessmer fmessmer mentioned this pull request Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants