Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Channels not being implemented and no ERROR #683

Closed
wfcooke opened this issue Jan 9, 2018 · 1 comment
Closed

Channels not being implemented and no ERROR #683

wfcooke opened this issue Jan 9, 2018 · 1 comment

Comments

@wfcooke
Copy link
Contributor

wfcooke commented Jan 9, 2018

When using the
MOM6-examples/ice_ocean_SIS2/OM4_025/INPUT/MOM_channels_global_025
file to create channels in SPEAR (1 deg coupled ocean) we are finding that the channels are not being implemented.
The problem occurs at
https://github.com/NOAA-GFDL/MOM6/blob/85c2ea0bf81b12a316fe40bc7713520f14a558fb/src/initialization/MOM_shared_initialization.F90#L907

and L926 where the input values are compared to the model values. If the input limits fall within a gridbox then the code does not create the limiting channel but does not report that it is not being created.

e.g.
U_width, -5.9, -5.4, 35.8, 36.2, 12000.0 ! Gibraltar
from ocean_static.nc
geolat_u 34.67->35.49->36.30 (in SPEAR)
geolon_u -6 -> -5 -> -4

-5.9, -5.4 falls between -6 and -5
35.8, 36.2, falls between 35.49->36.30

so we end up with a full width gridbox for the Gibraltar channel.

All 5 channels are not set for our setup

SUGGESTED FIX :
Add a FATAL error to bring the model down if the channel is not implemented.
(and then update the MOM_channel file for your model)
Hallberg-NOAA added a commit to Hallberg-NOAA/MOM6 that referenced this issue Nov 18, 2020
@Hallberg-NOAA
+Better error handling in reset_face_lengths_list
4f35f99 
  Added error handling to reset_face_lengths_list to note (and possibly trigger
a fatal error) for any entries in the CHANNEL_LIST_FILE that do not cause any
open face lengths to change. The runtime parameter FATAL_UNUSED_CHANNEL_WIDTHS
determines whether only warnings are issued or whether there should be a fatal
error; the default is false because otherwise a number of the Baltic test cases
that deliberately share files with global cases would fail due to channels
outside of their domains.  This PR addresses MOM6 issue mom-ocean#683, which should be
closed once this PR is merged in, although by default this new code triggers
warnings and not the suggested fatal error.  All answers are bitwise identical,
but there are new entries in some MOM_parameter_doc files.
@Hallberg-NOAA Hallberg-NOAA mentioned this issue Nov 18, 2020
Merged
@Hallberg-NOAA
Copy link
Collaborator

This issue has been addressed by the improved channel list error handling in PR#1251.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wfcooke @Hallberg-NOAA