+Better error handling in reset_face_lengths_list() #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added error handling to reset_face_lengths_list to note (and possibly trigger a fatal error) for any entries in the CHANNEL_LIST_FILE that do not cause any open face lengths to change. The runtime parameter FATAL_UNUSED_CHANNEL_WIDTHS determines whether only warnings are issued or whether there should be a fatal error; the default is false because otherwise a number of the Baltic test cases that deliberately share files with global cases would fail due to channels outside of their domains. This PR addresses MOM6 issue mom-ocean#683, which should be closed once this PR is merged in, although by default this new code triggers warnings and not the suggested fatal error. All answers are bitwise identical, but there are new entries in some MOM_parameter_doc files.
adcroft
reviewed
Nov 18, 2020
| @@ -889,16 +898,19 @@ subroutine reset_face_lengths_list(G, param_file, US) | |||
| call broadcast(num_lines, root_PE()) | |||
| u_pt = 0 ; v_pt = 0 | |||
| if (num_lines > 0) then | |||
| allocate (lines(num_lines)) | |||
| if (num_lines > 0) then | |||
adcroft
approved these changes
Nov 18, 2020
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1251 +/- ##
============================================
- Coverage 46.04% 46.02% -0.02%
============================================
Files 224 224
Lines 71037 71064 +27
============================================
Hits 32707 32707
- Misses 38330 38357 +27
Continue to review full report at Codecov.
|
|
https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/11547 ✔️ 🟡 Passes up to parameter change (as expected) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added error handling to reset_face_lengths_list() to note (and possibly trigger
a fatal error) for any entries in the CHANNEL_LIST_FILE that do not cause any
open face lengths to change. The runtime parameter FATAL_UNUSED_CHANNEL_WIDTHS
determines whether only warnings are issued or whether there should be a fatal
error; the default is false because otherwise a number of the Baltic test cases
that deliberately share files with global cases would fail due to channels
outside of their domains. This PR addresses MOM6 issue #683, which should be
closed once this PR is merged in, although by default this new code triggers
warnings and not the suggested fatal error. All answers are bitwise identical,
but there are new entries in some MOM_parameter_doc files.