Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low CodeCov coverage threshold #996

Merged
merged 3 commits into from
Sep 16, 2019

Conversation

marshallward
Copy link
Collaborator

Testing a lower coverage threshold for CodeCov testing, since the
current settings are distracting during this early stage of testing.

Testing a lower coverage threshold for CodeCov testing, since the
current settings are distracting from this early stage of testing.
@codecov-io
Copy link

codecov-io commented Sep 9, 2019

Codecov Report

❗ No coverage uploaded for pull request base (dev/gfdl@9f8a452). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             dev/gfdl     #996   +/-   ##
===========================================
  Coverage            ?   43.24%           
===========================================
  Files               ?      213           
  Lines               ?    62216           
  Branches            ?        0           
===========================================
  Hits                ?    26903           
  Misses              ?    35313           
  Partials            ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f8a452...9719ab3. Read the comment docs.

The absolute code coverage target was replaced with a 100% threshold,
tagging any level of coverage as a success.

This will be modified later, when the coverage tests are more thorough
and extendible by users.
@marshallward
Copy link
Collaborator Author

This patch appears to successfully disable the "failure" coverage report, but there seems to be an unrelated issue that is nonetheless relevant to testing: There are now two Travis "tests", and only one is being successfully reported while the other is still waiting.

I am not sure where this fourth "check" has come from:

 continuous-integration/travis-ci Expected — Waiting for status to be reported 

Reading a bit suggests that this is the older Travis CI, and that the newer one is reporting success:

Travis CI - Pull Request Successful in 15m — Build Passed 

I don't think this is caused by my patch, because #995 is showing the same problem, and is still using the older (current) Travis and CodeCov YAML files. None of the older PR seem to have this problem (e.g. #994, #993, #991) and appear to show the "old style" Travis report. So I don't know why things would have just suddenly flipped.

There are a few posts suggesting that we need to turn off the old style reporting, but it's just a guess. Shotgun googling comes up with this:

https://github.com/travis-ci/travis-ci/issues/10204

but there are a few other links saying the same thing. But this all appears to have happened about a year ago, so no idea why it's suddenly happening now.

@adcroft adcroft merged commit 43f9ea8 into mom-ocean:dev/gfdl Sep 16, 2019
@marshallward marshallward deleted the codecov_config branch February 13, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants