fix: fixes to some minor misc issues #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgautier404
requested review from
malandis,
eaddingtonwhite,
cprice404 and
poppoerika
and removed request for
malandis
cprice404
approved these changes
Mar 10, 2023
| @@ -27,7 +27,7 @@ type SortedSetIncrementScoreRequest struct { | |||
|
|
|||
| func (r *SortedSetIncrementScoreRequest) cacheName() string { return r.CacheName } | |||
|
|
|||
| func (r *SortedSetIncrementScoreRequest) requestName() string { return "Sorted set increment" } | |||
| func (r *SortedSetIncrementScoreRequest) requestName() string { return "Sorted set increment score" } | |||
There was a problem hiding this comment.
nit; some of the ones above use camel case here but these have spaces. probably standardizing on camel is best. not a blocker for 1.0.
There was a problem hiding this comment.
Yeah, that's a sorted set thing. I looked into where these are being used and they're informational only, so fine to fix when we get to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.