Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes to some minor misc issues #263

Merged
merged 1 commit into from
Mar 10, 2023
Merged

fix: fixes to some minor misc issues #263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion momento/dictionary_increment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ func (r *DictionaryIncrementRequest) ttl() time.Duration { return r.Ttl.Ttl }

func (r *DictionaryIncrementRequest) collectionTtl() *utils.CollectionTtl { return r.Ttl }

func (r *DictionaryIncrementRequest) requestName() string { return "DictionaryFetch" }
func (r *DictionaryIncrementRequest) requestName() string { return "DictionaryIncrement" }

func (r *DictionaryIncrementRequest) initGrpcRequest(client scsDataClient) error {
var err error
Expand Down
2 changes: 1 addition & 1 deletion momento/keys_exist.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ func (r *KeysExistRequest) cacheName() string { return r.CacheName }

func (r *KeysExistRequest) keys() []Key { return r.Keys }

func (r *KeysExistRequest) requestName() string { return "Get" }
func (r *KeysExistRequest) requestName() string { return "KeysExist" }

func (r *KeysExistRequest) initGrpcRequest(scsDataClient) error {
var err error
Expand Down
4 changes: 0 additions & 4 deletions momento/list_remove_value.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@ import (
pb "github.com/momentohq/client-sdk-go/internal/protos"
)

// ListRemoveValueResponse

// ListRemoveValueRequest

type ListRemoveValueRequest struct {
CacheName string
ListName string
Expand Down
2 changes: 1 addition & 1 deletion momento/sorted_set_increment_score.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ type SortedSetIncrementScoreRequest struct {

func (r *SortedSetIncrementScoreRequest) cacheName() string { return r.CacheName }

func (r *SortedSetIncrementScoreRequest) requestName() string { return "Sorted set increment" }
func (r *SortedSetIncrementScoreRequest) requestName() string { return "Sorted set increment score" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit; some of the ones above use camel case here but these have spaces. probably standardizing on camel is best. not a blocker for 1.0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's a sorted set thing. I looked into where these are being used and they're informational only, so fine to fix when we get to it.


func (r *SortedSetIncrementScoreRequest) value() Value { return r.Value }

Expand Down
2 changes: 1 addition & 1 deletion momento/sorted_set_put_elements.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ type SortedSetPutElementsRequest struct {

func (r *SortedSetPutElementsRequest) cacheName() string { return r.CacheName }

func (r *SortedSetPutElementsRequest) requestName() string { return "Sorted set put" }
func (r *SortedSetPutElementsRequest) requestName() string { return "Sorted set put elements" }

func (r *SortedSetPutElementsRequest) ttl() time.Duration { return r.Ttl.Ttl }

Expand Down
2 changes: 1 addition & 1 deletion momento/sorted_set_remove_elements.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ type SortedSetRemoveElementsRequest struct {

func (r *SortedSetRemoveElementsRequest) cacheName() string { return r.CacheName }

func (r *SortedSetRemoveElementsRequest) requestName() string { return "Sorted set remove" }
func (r *SortedSetRemoveElementsRequest) requestName() string { return "Sorted set remove elements" }

func (r *SortedSetRemoveElementsRequest) values() []Value { return r.Values }

Expand Down