Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback form - mentioned but not hyperlinked at the top of home page #473

Closed
nlharris opened this issue Nov 15, 2023 · 1 comment · Fixed by #482
Closed

Feedback form - mentioned but not hyperlinked at the top of home page #473

nlharris opened this issue Nov 15, 2023 · 1 comment · Fixed by #482
Assignees

Comments

@nlharris
Copy link
Member

At the very top of monarchinitiative.org, it says

This web app is the successor to the old web app here. Not all features are implemented yet. Please use the feedback form to tell us what you think!

There's a convenient link to the old web app, but no link to the feedback form. It's not hard to find under "Help", but why not make it as easy as possible for users to find by hyperlinking "feedback form" to https://monarchinitiative.org/feedback? (I can do a PR to make that change, if that sounds ok.)

I also noticed that on the Help page, it says

Feedback Form
Right here, no account required, one-way

but if you go to the feedback form, it says

Email
So we can follow up with you

so it's NOT one-way, and in fact, lower down, it mentions that using the feedback form creates a public GitHub issue, which is of course two-way.

@vincerubinetti
Copy link
Contributor

vincerubinetti commented Nov 17, 2023

The feedback form is accessible from any page by the speech bubble icon in the lower right corner. We want to encourage users to use that instead of /feedback because it is specific to whatever page the user is currently on. This is the change I will make to address your comment:

Screenshot 2023-11-17 at 12 03 58 PM

so it's NOT one-way

The name/email/username are optional. It is one-way because if you do not enter these things (which is very likely when they are optional), you are sending an issue off to the help desk without any way to identify your or respond to you. That is the point of saying one-way, and it should be clear to the user that that is the case.

However since these terms appear to be confusing, I'll remove them and hope users understand the difference between the Feedback Form and Help Desk links on the help page at a glance.

@kevinschaper kevinschaper added this to the 2023-12 Release milestone Nov 21, 2023
kevinschaper pushed a commit that referenced this issue Dec 8, 2023
closes #473 
closes #481 
closes #475

- add more explanation and icon to banner about feedback form
- expose imperative "runsearch" func from tags component
- show text next to table expand/collapse button to make more obvious
- modify phenotype explorer to accept search term from history state
- add button to node page association section to send phenotypes to
pheno explorer
- add strikethrough for deprecated nodes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants