Fix Phenogrid results error when changing order (sort) of input phenotypes #755
Comments
ptgolden
pushed a commit
that referenced
this issue
Nov 14, 2024
Previously, the key on the element being rendered was the index of the array of cells. When cells were reordered (or, I imagine, transposed), they were not being re-rendered because even though the array was shuffled, the index stayed constant. This commit creates a compound identifier for each cell consisting of the ID of the row and the ID of the column. This uniquely identifies each cell in the grid. Fixes #755
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Where: dev.monarchinitative.org
When: 2024/07/07 21h21m
What: When inspecting the results of Phenotype Explorer, I changed the order of the results using the 'Sort' dropdown menu. The order changed, but the information about the comparison and values for each score still corresponded to the previous pair.
To reproduce:
I entered these phenotypes: MP:0008752,MP:0008750,MP:0008751,MP:0004045,MP:0010170,MP:0020449,MP:0003691,MP:0003884,MP:0001599,MP:0011986,MP:0008596,MP:0008553,MP:0011080,MP:0002078,MP:0001798,MP:0008735
To compare them to "phenotypes from these genes/diseases..." (selected from dropdown menu)| "Human Diseases" (selected from dropdown menu), using AIC (selected from dropdown menu).
The resulting Phenogrid shows this information when I hover over the upper left square in the grid (screenshot).
When I use the 'Sort' option to reorganize by highest score, the phenotypes are reorganized, but when I hover over the same square, the same information that appears belongs to the previously compared phenotypes. That information is NOT being reorganized (screenshot). This is an error.
The text was updated successfully, but these errors were encountered: