Improve association table search #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for monarch-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kevinschaper
force-pushed
the
issue-264-association-table-search
branch
from
3a2bd5b to
29f0f01
Compare
glass-ships
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially, this PR is a little disapointing.
It expands the searched fields to include closure IDs and labels, as well as evidence fields...the thing is, those fields aren't tokenized, they're all keywords, which means my use case of finding the one skeletal phenotype associated with Glaucoma requires putting the exact HPO term name into the search box, and wrapping it in quotes. (🙄)
So, I'm getting this in place, and I'm going to add additional fields declarations and copy-field statements for association indexing in monarch-ingest.