Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix feedback submit on safari, simplify api url #418

Merged
merged 1 commit into from
Oct 20, 2023
Merged

fix feedback submit on safari, simplify api url #418

merged 1 commit into from
Oct 20, 2023

Conversation

vincerubinetti
Copy link
Contributor

@vincerubinetti vincerubinetti commented Oct 20, 2023 •
edited
Loading

  • delete several old unused fixture data
  • rename "monarch" to "apiUrl"
  • simplify api url logic, make relative by default
  • fix feedback form not submitting on safari

@netlify
Copy link

netlify bot commented Oct 20, 2023

✅ Deploy Preview for monarch-app ready!

Name Link
🔨 Latest commit 3524e32
🔍 Latest deploy log https://app.netlify.com/sites/monarch-app/deploys/6531f2e9a546c50008522e80
😎 Deploy Preview https://deploy-preview-418--monarch-app.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vincerubinetti vincerubinetti merged commit 9af4c4b into main Oct 20, 2023
9 checks passed
@vincerubinetti vincerubinetti deleted the fix-feedback branch October 20, 2023 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinschaper kevinschaper kevinschaper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincerubinetti @kevinschaper